Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2133153002: Make DocumentResource to be a subclass of TextResource (Closed)

Created:
4 years, 5 months ago by hiroshige
Modified:
4 years, 5 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DocumentResource to be a subclass of TextResource BUG=None Committed: https://crrev.com/d74b7d281924602076044e6fb481cefde5ab95b2 Cr-Commit-Position: refs/heads/master@{#404625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -20 lines) Patch
M third_party/WebKit/Source/core/fetch/DocumentResource.h View 4 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/DocumentResource.cpp View 2 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
hiroshige
PTAL.
4 years, 5 months ago (2016-07-11 07:50:12 UTC) #8
Mike West
LGTM.
4 years, 5 months ago (2016-07-11 08:08:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133153002/1
4 years, 5 months ago (2016-07-11 08:19:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 09:49:53 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 09:49:54 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 09:52:13 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d74b7d281924602076044e6fb481cefde5ab95b2
Cr-Commit-Position: refs/heads/master@{#404625}

Powered by Google App Engine
This is Rietveld 408576698