third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-multiple-attach.html - Issue 2133143003: Allow multiple URL.createObjectURL invocations for MediaSource

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-multiple-attach.html

Issue 2133143003: Allow multiple URL.createObjectURL invocations for MediaSource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="/w3c/resources/testharness.js"></script>	4 <script src="/w3c/resources/testharness.js"></script>

5 <script src="/w3c/resources/testharnessreport.js"></script>	5 <script src="/w3c/resources/testharnessreport.js"></script>

6 <script src="mediasource-util.js"></script>	6 <script src="mediasource-util.js"></script>

7 <link rel='stylesheet' href='/w3c/resources/testharness.css'>	7 <link rel='stylesheet' href='/w3c/resources/testharness.css'>

8 </head>	8 </head>

9 <body>	9 <body>

10 <div id="log"></div>	10 <div id="log"></div>

(...skipping 90 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
101 test.expectEvent(mediaSource, 'sourceopen', 'Source attached again ');	101 test.expectEvent(mediaSource, 'sourceopen', 'Source attached again ');

102 mediaElement.src = URL.createObjectURL(mediaSource);	102 mediaElement.src = URL.createObjectURL(mediaSource);

103 assert_equals(mediaSource.readyState, 'closed', 'Source closed');	103 assert_equals(mediaSource.readyState, 'closed', 'Source closed');

104	104

105 test.waitForExpectedEvents(function()	105 test.waitForExpectedEvents(function()

106 {	106 {

107 assert_equals(mediaSource.readyState, 'open', 'Source reopened ');	107 assert_equals(mediaSource.readyState, 'open', 'Source reopened ');

108 test.done();	108 test.done();

109 });	109 });

110 }, 'Test that MediaSource can reattach if closed first');	110 }, 'Test that MediaSource can reattach if closed first');

	111

	112 mediasource_test(function(test, mediaElement, mediaSource) {

	113 assert_equals(mediaSource.readyState, 'open', 'Source open');

	114 var url1 = URL.createObjectURL(mediaSource);

	115 var url2 = URL.createObjectURL(mediaSource);

	116 assert_not_equals(url1, url2, 'URLs not unique');

	117 test.done();

	118 }, 'Calling URL.createObjectURL multiple times should generate unique URLs each time');
	wolenetz 2016/07/11 18:03:17 I like this new test. Please also consider adding I like this new test. Please also consider adding coverage that verifies that url1, if revoked, doesn't prevent url2 from being used to dereference mediaSource (and that url1, once revoked, can't be used to dereference mediaSource). The latter might overlap existing coverage a little, but I think would still add value given that we're testing more than one objectURL for the same mediaSource here. servolk 2016/07/11 18:13:25 Done. Show quoted text On 2016/07/11 18:03:17, wolenetz wrote: > I like this new test. Please also consider adding coverage that verifies that > url1, if revoked, doesn't prevent url2 from being used to dereference > mediaSource (and that url1, once revoked, can't be used to dereference > mediaSource). The latter might overlap existing coverage a little, but I think > would still add value given that we're testing more than one objectURL for the > same mediaSource here. Done.
111 </script>	119 </script>

112 </body>	120 </body>

113 </html>	121 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/mediasource/MediaSource.h » ('j') | third_party/WebKit/Source/modules/mediasource/MediaSource.cpp » ('J')