Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 213313007: Revert of Extract RuntimeEventRouter from extensions Runtime API (Closed)

Created:
6 years, 9 months ago by James Cook
Modified:
6 years, 9 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Revert of Extract RuntimeEventRouter from extensions Runtime API (https://codereview.chromium.org/206613005/) Reason for revert: After talking to yoz@ and rockot@ I don't think we want to extract the runtime implementation to src/extensions. It's got too much Chrome-specific stuff, and for app_shell we really need app_runtime and not runtime. Original issue's description: > Extract RuntimeEventRouter from extensions Runtime API > > Another step toward moving the runtime API to src/extensions so it can be > used by app_shell. > > BUG=354552 > TEST=browser_tests ExtensionApi*:*Runtime* > TBR=xiyuan@chromium.org for header file move touching chrome/browser/chromeos/app_mode > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259477 TBR=yoz@chromium.org NOTREECHECKS=true NOTRY=true BUG=354552 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -268 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_update_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.h View 3 chunks +37 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 14 chunks +156 lines, -32 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
D extensions/browser/api/runtime/runtime_event_router.h View 1 chunk +0 lines, -59 lines 0 comments Download
D extensions/browser/api/runtime/runtime_event_router.cc View 1 chunk +0 lines, -165 lines 0 comments Download
M extensions/browser/process_manager.cc View 3 chunks +1 line, -4 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
James Cook
Created Revert of Extract RuntimeEventRouter from extensions Runtime API
6 years, 9 months ago (2014-03-27 00:08:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/213313007/1
6 years, 9 months ago (2014-03-27 00:08:30 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 00:14:47 UTC) #3
Message was sent while issue was closed.
Change committed as 259755

Powered by Google App Engine
This is Rietveld 408576698