Issue 213313004: Add creation of ServiceManager to Content (2nd try)

Issue 213313004: Add creation of ServiceManager to Content (2nd try) (Closed)

Created:
6 years, 9 months ago by DaveMoore

Modified:
6 years, 9 months ago

Reviewers:

CC:
chromium-reviews, viettrungluu+watch_chromium.org, jam, abarth-chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add creation of ServiceManager to Content (2nd try) Original cl: https://codereview.chromium.org/187183002/ BUG= TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259779

Patch Set 1 #

Patch Set 2 : Use base::MessageLoop in test #

Patch Set 3 : Add shell_client to mojo_pepper_container_app #

Patch Set 4 : Add shell_client to mojo_pepper_container_app #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+240 lines, -60 lines)			Patch
M	content/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/app/content_main_runner.cc	View		3 chunks	+10 lines, -1 line	0 comments	Download
A	content/app/mojo/mojo_browsertest.cc	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	content/app/mojo/mojo_init.h	View		1 chunk	+15 lines, -0 lines	0 comments	Download
A	content/app/mojo/mojo_init.cc	View		1 chunk	+34 lines, -0 lines	0 comments	Download
M	content/browser/webui/web_ui_mojo_browsertest.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/common/mojo/mojo_channel_init.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/common/mojo/mojo_channel_init.cc	View	1	2 chunks	+0 lines, -24 lines	0 comments	Download
M	content/content_app.gypi	View		2 chunks	+15 lines, -0 lines	0 comments	Download
M	content/content_common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/content_tests.gypi	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	mojo/mojo.gyp	View	1	4 chunks	+12 lines, -5 lines	0 comments	Download
M	mojo/mojo_examples.gypi	View	1 2	6 chunks	+7 lines, -6 lines	0 comments	Download
M	mojo/mojo_public.gypi	View		2 chunks	+16 lines, -5 lines	0 comments	Download
M	mojo/mojo_services.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/service_manager/service_loader.h	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	mojo/service_manager/service_manager.h	View	1	2 chunks	+13 lines, -3 lines	0 comments	Download
M	mojo/service_manager/service_manager.cc	View	1	6 chunks	+19 lines, -5 lines	0 comments	Download
A	mojo/service_manager/service_manager_export.h	View		1 chunk	+32 lines, -0 lines	0 comments	Download
M	mojo/service_manager/service_manager_unittest.cc	View	1	4 chunks	+9 lines, -3 lines	0 comments	Download
M	mojo/shell/android/mojo_main.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	mojo/shell/dynamic_service_loader.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/shell/dynamic_service_loader.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/213313004/60001

6 years, 9 months ago (2014-03-27 00:59:34 UTC) #4

Message was sent while issue was closed.

Change committed as 259779

Expand Messages | Collapse Messages