Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2133093002: [system-health] Enable browser logging in the smoke test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use string literal Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run all system health stories used by system health benchmarks. 5 """Run all system health stories used by system health benchmarks.
6 6
7 Only memory benchmarks are used when running these stories to make the total 7 Only memory benchmarks are used when running these stories to make the total
8 cycle time manageable. Other system health benchmarks should be using the same 8 cycle time manageable. Other system health benchmarks should be using the same
9 stories as memory ones, only with fewer actions (no memory dumping). 9 stories as memory ones, only with fewer actions (no memory dumping).
10 """ 10 """
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 benchmark_class.AddCommandLineArgs(parser) 109 benchmark_class.AddCommandLineArgs(parser)
110 benchmark_module.AddCommandLineArgs(parser) 110 benchmark_module.AddCommandLineArgs(parser)
111 benchmark_class.SetArgumentDefaults(parser) 111 benchmark_class.SetArgumentDefaults(parser)
112 options.MergeDefaultValues(parser.get_default_values()) 112 options.MergeDefaultValues(parser.get_default_values())
113 113
114 benchmark_class.ProcessCommandLineArgs(None, options) 114 benchmark_class.ProcessCommandLineArgs(None, options)
115 benchmark_module.ProcessCommandLineArgs(None, options) 115 benchmark_module.ProcessCommandLineArgs(None, options)
116 # Only measure a single story so that this test cycles reasonably quickly. 116 # Only measure a single story so that this test cycles reasonably quickly.
117 options.pageset_repeat = 1 117 options.pageset_repeat = 1
118 options.page_repeat = 1 118 options.page_repeat = 1
119 # Enable browser logging in the smoke test only (crbug.com/625172).
120 options.logging_verbosity = 'non-verbose'
119 return options 121 return options
120 122
121 123
122 def load_tests(loader, standard_tests, pattern): 124 def load_tests(loader, standard_tests, pattern):
123 del loader, standard_tests, pattern # unused 125 del loader, standard_tests, pattern # unused
124 suite = progress_reporter.TestSuite() 126 suite = progress_reporter.TestSuite()
125 benchmark_classes = GetSystemHealthBenchmarksToSmokeTest() 127 benchmark_classes = GetSystemHealthBenchmarksToSmokeTest()
126 assert benchmark_classes, 'This list should never be empty' 128 assert benchmark_classes, 'This list should never be empty'
127 for benchmark_class in benchmark_classes: 129 for benchmark_class in benchmark_classes:
128 130
129 # HACK: these options should be derived from options_for_unittests which are 131 # HACK: these options should be derived from options_for_unittests which are
130 # the resolved options from run_tests' arguments. However, options is only 132 # the resolved options from run_tests' arguments. However, options is only
131 # parsed during test time which happens after load_tests are called. 133 # parsed during test time which happens after load_tests are called.
132 # Since none of our system health benchmarks creates stories based on 134 # Since none of our system health benchmarks creates stories based on
133 # command line options, it should be ok to pass options=None to 135 # command line options, it should be ok to pass options=None to
134 # CreateStorySet. 136 # CreateStorySet.
135 for story_to_smoke_test in ( 137 for story_to_smoke_test in (
136 benchmark_class().CreateStorySet(options=None).stories): 138 benchmark_class().CreateStorySet(options=None).stories):
137 suite.addTest( 139 suite.addTest(
138 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) 140 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
139 141
140 return suite 142 return suite
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698