Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: media/PRESUBMIT.py

Issue 2133083002: Remove all remaining traces of MessageLoopProxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/PRESUBMIT.py
diff --git a/media/PRESUBMIT.py b/media/PRESUBMIT.py
index 02bd02bf01b13a3588e909b9ac1ea54eb4b71d68..830c3fc76d279d78363443b52429231287e1dc7a 100644
--- a/media/PRESUBMIT.py
+++ b/media/PRESUBMIT.py
@@ -77,29 +77,6 @@ def _CheckForUseOfWrongClock(input_api, output_api):
return []
-def _CheckForMessageLoopProxy(input_api, output_api):
- """Make sure media code only uses MessageLoopProxy for accessing the current
- loop."""
-
- message_loop_proxy_re = input_api.re.compile(
- r'\bMessageLoopProxy(?!::current\(\))')
-
- problems = []
- for f in input_api.AffectedSourceFiles(_FilterFile):
- for line_number, line in f.ChangedContents():
- if message_loop_proxy_re.search(line):
- problems.append('%s:%d' % (f.LocalPath(), line_number))
-
- if problems:
- return [output_api.PresubmitError(
- 'MessageLoopProxy should only be used for accessing the current loop.\n'
- 'Use the TaskRunner interfaces instead as they are more explicit about\n'
- 'the run-time characteristics. In most cases, SingleThreadTaskRunner\n'
- 'is a drop-in replacement for MessageLoopProxy.', problems)]
-
- return []
-
-
def _CheckForHistogramOffByOne(input_api, output_api):
"""Make sure histogram enum maxes are used properly"""
@@ -193,7 +170,6 @@ def _CheckPassByValue(input_api, output_api):
def _CheckChange(input_api, output_api):
results = []
results.extend(_CheckForUseOfWrongClock(input_api, output_api))
- results.extend(_CheckForMessageLoopProxy(input_api, output_api))
results.extend(_CheckPassByValue(input_api, output_api))
results.extend(_CheckForHistogramOffByOne(input_api, output_api))
results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
« no previous file with comments | « ios/chrome/browser/net/ios_chrome_url_request_context_getter.h ('k') | net/url_request/url_request_context_getter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698