Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1469)

Unified Diff: content/renderer/media/gpu/rtc_video_decoder.h

Issue 2133083002: Remove all remaining traces of MessageLoopProxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/mock_render_thread.cc ('k') | content/renderer/pepper/host_globals.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/gpu/rtc_video_decoder.h
diff --git a/content/renderer/media/gpu/rtc_video_decoder.h b/content/renderer/media/gpu/rtc_video_decoder.h
index 274f6dfb6f6e77fda06fbd2afc7191e79ff2a4f0..d77220f5e4b6aa6d05bb681c86e757f6090faa2d 100644
--- a/content/renderer/media/gpu/rtc_video_decoder.h
+++ b/content/renderer/media/gpu/rtc_video_decoder.h
@@ -43,11 +43,11 @@ struct SyncToken;
namespace content {
// This class uses hardware accelerated video decoder to decode video for
-// WebRTC. |vda_message_loop_| is the message loop proxy of the media thread,
-// which VDA::Client methods run on. webrtc::VideoDecoder methods run on WebRTC
-// DecodingThread or Chrome_libJingle_WorkerThread, which are trampolined to
-// |vda_message_loop_|. Decode() is non-blocking and queues the buffers. Decoded
-// frames are delivered to WebRTC on |vda_message_loop_|.
+// WebRTC. Lives on the media thread, where VDA::Client methods run on.
+// webrtc::VideoDecoder methods run on WebRTC DecodingThread or
+// Chrome_libJingle_WorkerThread, which are trampolined to the media thread.
+// Decode() is non-blocking and queues the buffers. Decoded frames are
+// delivered to WebRTC on the media task runner.
class CONTENT_EXPORT RTCVideoDecoder
: NON_EXPORTED_BASE(public webrtc::VideoDecoder),
public media::VideoDecodeAccelerator::Client {
@@ -163,7 +163,7 @@ class CONTENT_EXPORT RTCVideoDecoder
// Tells VDA that a picture buffer can be recycled.
void ReusePictureBuffer(int64_t picture_buffer_id);
- // Creates |vda_| on |vda_loop_proxy_|.
+ // Creates |vda_| on the media thread.
void CreateVDA(media::VideoCodecProfile profile, base::WaitableEvent* waiter);
void DestroyTextures();
@@ -294,7 +294,7 @@ class CONTENT_EXPORT RTCVideoDecoder
gfx::Size min_resolution_;
gfx::Size max_resolution_;
- // Must be destroyed, or invalidated, on |vda_loop_proxy_|
+ // Must be destroyed, or invalidated, on the media thread.
// NOTE: Weak pointers must be invalidated before all other member variables.
base::WeakPtrFactory<RTCVideoDecoder> weak_factory_;
« no previous file with comments | « content/public/test/mock_render_thread.cc ('k') | content/renderer/pepper/host_globals.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698