chrome/browser/safe_browsing/ui_manager_unittest.cc - Issue 2133083002: Remove all remaining traces of MessageLoopProxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/ui_manager_unittest.cc

Issue 2133083002: Remove all remaining traces of MessageLoopProxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/two_phase_uploader_unittest.cc ('k') | chrome/browser/search/suggestions/suggestions_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/ui_manager_unittest.cc

diff --git a/chrome/browser/safe_browsing/ui_manager_unittest.cc b/chrome/browser/safe_browsing/ui_manager_unittest.cc

index 12137334265056cff66c58b2bfc64988d5f50fd1..9516f37183e72ea845ea0d118bd165dcd6ac39e9 100644

--- a/chrome/browser/safe_browsing/ui_manager_unittest.cc

+++ b/chrome/browser/safe_browsing/ui_manager_unittest.cc

@@ -205,7 +205,7 @@ TEST_F(SafeBrowsingUIManagerTest, UICallbackProceed) {

base::Bind(&SafeBrowsingCallbackWaiter::OnBlockingPageDone,

base::Unretained(&waiter));

resource.callback_thread =

- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI);

+ BrowserThread::GetTaskRunnerForThread(BrowserThread::UI);

std::vector<SafeBrowsingUIManager::UnsafeResource> resources;

resources.push_back(resource);

SimulateBlockingPageDone(resources, true);

@@ -223,7 +223,7 @@ TEST_F(SafeBrowsingUIManagerTest, UICallbackDontProceed) {

base::Bind(&SafeBrowsingCallbackWaiter::OnBlockingPageDone,

base::Unretained(&waiter));

resource.callback_thread =

- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI);

+ BrowserThread::GetTaskRunnerForThread(BrowserThread::UI);

std::vector<SafeBrowsingUIManager::UnsafeResource> resources;

resources.push_back(resource);

SimulateBlockingPageDone(resources, false);

@@ -241,7 +241,7 @@ TEST_F(SafeBrowsingUIManagerTest, IOCallbackProceed) {

base::Bind(&SafeBrowsingCallbackWaiter::OnBlockingPageDoneOnIO,

base::Unretained(&waiter));

resource.callback_thread =

- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO);

+ BrowserThread::GetTaskRunnerForThread(BrowserThread::IO);

std::vector<SafeBrowsingUIManager::UnsafeResource> resources;

resources.push_back(resource);

SimulateBlockingPageDone(resources, true);

@@ -259,7 +259,7 @@ TEST_F(SafeBrowsingUIManagerTest, IOCallbackDontProceed) {

base::Bind(&SafeBrowsingCallbackWaiter::OnBlockingPageDoneOnIO,

base::Unretained(&waiter));

resource.callback_thread =

- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO);

+ BrowserThread::GetTaskRunnerForThread(BrowserThread::IO);

std::vector<SafeBrowsingUIManager::UnsafeResource> resources;

resources.push_back(resource);

SimulateBlockingPageDone(resources, false);