chrome/browser/password_manager/password_store_proxy_mac_unittest.cc - Issue 2133083002: Remove all remaining traces of MessageLoopProxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

Issue 2133083002: Remove all remaining traces of MessageLoopProxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_factory.cc ('k') | chrome/browser/password_manager/password_store_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

diff --git a/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc b/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

index bcdd8ce96ad7e3561eba2a2084c8c400dc6b0715..ee1bac1c904f3647dc97c51a6d143d8afbd772dd 100644

--- a/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

+++ b/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

@@ -160,7 +160,7 @@ void PasswordStoreProxyMacTest::TearDown() {

void PasswordStoreProxyMacTest::CreateAndInitPasswordStore(

std::unique_ptr<password_manager::LoginDatabase> login_db) {

store_ = new PasswordStoreProxyMac(

- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI),

+ BrowserThread::GetTaskRunnerForThread(BrowserThread::UI),

base::WrapUnique(new crypto::MockAppleKeychain), std::move(login_db),

&testing_prefs_);

ASSERT_TRUE(store_->Init(syncer::SyncableService::StartSyncFlare()));

@@ -456,7 +456,7 @@ void PasswordStoreProxyMacMigrationTest::TestMigration(bool lock_keychain) {

if (lock_keychain)

keychain_->set_locked(true);

store_ = new PasswordStoreProxyMac(

- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI),

+ BrowserThread::GetTaskRunnerForThread(BrowserThread::UI),

std::move(keychain_), std::move(login_db_), &testing_prefs_);

ASSERT_TRUE(store_->Init(syncer::SyncableService::StartSyncFlare()));

FinishAsyncProcessing();