Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Side by Side Diff: net/url_request/url_request_context_getter.cc

Issue 2133083002: Remove all remaining traces of MessageLoopProxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/PRESUBMIT.py ('k') | ppapi/host/resource_message_filter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_context_getter.h" 5 #include "net/url_request/url_request_context_getter.h"
6 6
7 #include "base/debug/leak_annotations.h" 7 #include "base/debug/leak_annotations.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "net/url_request/url_request_context.h" 10 #include "net/url_request/url_request_context.h"
(...skipping 29 matching lines...) Expand all
40 // Can't force-delete the object here, because some derived classes 40 // Can't force-delete the object here, because some derived classes
41 // can only be deleted on the owning thread, so just emit a warning to 41 // can only be deleted on the owning thread, so just emit a warning to
42 // aid in debugging. 42 // aid in debugging.
43 DLOG(WARNING) << "URLRequestContextGetter leaking due to no owning" 43 DLOG(WARNING) << "URLRequestContextGetter leaking due to no owning"
44 << " thread."; 44 << " thread.";
45 // Let LSan know we know this is a leak. https://crbug.com/594130 45 // Let LSan know we know this is a leak. https://crbug.com/594130
46 ANNOTATE_LEAKING_OBJECT_PTR(this); 46 ANNOTATE_LEAKING_OBJECT_PTR(this);
47 } 47 }
48 } 48 }
49 } 49 }
50 // If no IO message loop proxy was available, we will just leak memory. 50 // If no IO task runner was available, we will just leak memory.
51 // This is also true if the IO thread is gone. 51 // This is also true if the IO thread is gone.
52 } 52 }
53 53
54 void URLRequestContextGetter::NotifyContextShuttingDown() { 54 void URLRequestContextGetter::NotifyContextShuttingDown() {
55 DCHECK(GetNetworkTaskRunner()->BelongsToCurrentThread()); 55 DCHECK(GetNetworkTaskRunner()->BelongsToCurrentThread());
56 56
57 // Once shutdown starts, this must always return NULL. 57 // Once shutdown starts, this must always return NULL.
58 DCHECK(!GetURLRequestContext()); 58 DCHECK(!GetURLRequestContext());
59 59
60 FOR_EACH_OBSERVER(URLRequestContextGetterObserver, observer_list_, 60 FOR_EACH_OBSERVER(URLRequestContextGetterObserver, observer_list_,
(...skipping 12 matching lines...) Expand all
73 return context_; 73 return context_;
74 } 74 }
75 75
76 scoped_refptr<base::SingleThreadTaskRunner> 76 scoped_refptr<base::SingleThreadTaskRunner>
77 TrivialURLRequestContextGetter::GetNetworkTaskRunner() const { 77 TrivialURLRequestContextGetter::GetNetworkTaskRunner() const {
78 return main_task_runner_; 78 return main_task_runner_;
79 } 79 }
80 80
81 81
82 } // namespace net 82 } // namespace net
OLDNEW
« no previous file with comments | « media/PRESUBMIT.py ('k') | ppapi/host/resource_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698