Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: chrome/browser/safe_browsing/two_phase_uploader_unittest.cc

Issue 2133083002: Remove all remaining traces of MessageLoopProxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/two_phase_uploader.h" 5 #include "chrome/browser/safe_browsing/two_phase_uploader.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 return file_path; 58 return file_path;
59 } 59 }
60 60
61 } // namespace 61 } // namespace
62 62
63 class TwoPhaseUploaderTest : public testing::Test { 63 class TwoPhaseUploaderTest : public testing::Test {
64 public: 64 public:
65 TwoPhaseUploaderTest() 65 TwoPhaseUploaderTest()
66 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP), 66 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
67 url_request_context_getter_(new net::TestURLRequestContextGetter( 67 url_request_context_getter_(new net::TestURLRequestContextGetter(
68 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO))) { 68 BrowserThread::GetTaskRunnerForThread(BrowserThread::IO))) {}
69 }
70 69
71 protected: 70 protected:
72 content::TestBrowserThreadBundle thread_bundle_; 71 content::TestBrowserThreadBundle thread_bundle_;
73 72
74 scoped_refptr<net::TestURLRequestContextGetter> url_request_context_getter_; 73 scoped_refptr<net::TestURLRequestContextGetter> url_request_context_getter_;
75 }; 74 };
76 75
77 TEST_F(TwoPhaseUploaderTest, UploadFile) { 76 TEST_F(TwoPhaseUploaderTest, UploadFile) {
78 scoped_refptr<MessageLoopRunner> runner = new MessageLoopRunner; 77 scoped_refptr<MessageLoopRunner> runner = new MessageLoopRunner;
79 LocalTwoPhaseTestServer test_server; 78 LocalTwoPhaseTestServer test_server;
80 ASSERT_TRUE(test_server.Start()); 79 ASSERT_TRUE(test_server.Start());
81 Delegate delegate; 80 Delegate delegate;
82 std::unique_ptr<TwoPhaseUploader> uploader(TwoPhaseUploader::Create( 81 std::unique_ptr<TwoPhaseUploader> uploader(TwoPhaseUploader::Create(
83 url_request_context_getter_.get(), 82 url_request_context_getter_.get(),
84 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB).get(), 83 BrowserThread::GetTaskRunnerForThread(BrowserThread::DB).get(),
85 test_server.GetURL("start"), "metadata", GetTestFilePath(), 84 test_server.GetURL("start"), "metadata", GetTestFilePath(),
86 base::Bind(&Delegate::ProgressCallback, base::Unretained(&delegate)), 85 base::Bind(&Delegate::ProgressCallback, base::Unretained(&delegate)),
87 base::Bind(&Delegate::FinishCallback, base::Unretained(&delegate), 86 base::Bind(&Delegate::FinishCallback, base::Unretained(&delegate),
88 runner))); 87 runner)));
89 uploader->Start(); 88 uploader->Start();
90 runner->Run(); 89 runner->Run();
91 EXPECT_EQ(TwoPhaseUploader::STATE_SUCCESS, delegate.state_); 90 EXPECT_EQ(TwoPhaseUploader::STATE_SUCCESS, delegate.state_);
92 EXPECT_EQ(net::OK, delegate.net_error_); 91 EXPECT_EQ(net::OK, delegate.net_error_);
93 EXPECT_EQ(200, delegate.response_code_); 92 EXPECT_EQ(200, delegate.response_code_);
94 EXPECT_EQ( 93 EXPECT_EQ(
95 "/start\n" // path of start request 94 "/start\n" // path of start request
96 "4c24b2612e94e2ae622e54397663f2b7bf0a2e17\n" // sha1sum of "metadata" 95 "4c24b2612e94e2ae622e54397663f2b7bf0a2e17\n" // sha1sum of "metadata"
97 "944857cc626f2cafe232521986b4c6d3f9993c97\n", // sha1sum of test file 96 "944857cc626f2cafe232521986b4c6d3f9993c97\n", // sha1sum of test file
98 delegate.response_); 97 delegate.response_);
99 } 98 }
100 99
101 TEST_F(TwoPhaseUploaderTest, BadPhaseOneResponse) { 100 TEST_F(TwoPhaseUploaderTest, BadPhaseOneResponse) {
102 scoped_refptr<MessageLoopRunner> runner = new MessageLoopRunner; 101 scoped_refptr<MessageLoopRunner> runner = new MessageLoopRunner;
103 LocalTwoPhaseTestServer test_server; 102 LocalTwoPhaseTestServer test_server;
104 ASSERT_TRUE(test_server.Start()); 103 ASSERT_TRUE(test_server.Start());
105 Delegate delegate; 104 Delegate delegate;
106 std::unique_ptr<TwoPhaseUploader> uploader(TwoPhaseUploader::Create( 105 std::unique_ptr<TwoPhaseUploader> uploader(TwoPhaseUploader::Create(
107 url_request_context_getter_.get(), 106 url_request_context_getter_.get(),
108 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB).get(), 107 BrowserThread::GetTaskRunnerForThread(BrowserThread::DB).get(),
109 test_server.GetURL("start?p1code=500"), "metadata", GetTestFilePath(), 108 test_server.GetURL("start?p1code=500"), "metadata", GetTestFilePath(),
110 base::Bind(&Delegate::ProgressCallback, base::Unretained(&delegate)), 109 base::Bind(&Delegate::ProgressCallback, base::Unretained(&delegate)),
111 base::Bind(&Delegate::FinishCallback, base::Unretained(&delegate), 110 base::Bind(&Delegate::FinishCallback, base::Unretained(&delegate),
112 runner))); 111 runner)));
113 uploader->Start(); 112 uploader->Start();
114 runner->Run(); 113 runner->Run();
115 EXPECT_EQ(TwoPhaseUploader::UPLOAD_METADATA, delegate.state_); 114 EXPECT_EQ(TwoPhaseUploader::UPLOAD_METADATA, delegate.state_);
116 EXPECT_EQ(net::OK, delegate.net_error_); 115 EXPECT_EQ(net::OK, delegate.net_error_);
117 EXPECT_EQ(500, delegate.response_code_); 116 EXPECT_EQ(500, delegate.response_code_);
118 EXPECT_EQ("", delegate.response_); 117 EXPECT_EQ("", delegate.response_);
119 } 118 }
120 119
121 TEST_F(TwoPhaseUploaderTest, BadPhaseTwoResponse) { 120 TEST_F(TwoPhaseUploaderTest, BadPhaseTwoResponse) {
122 scoped_refptr<MessageLoopRunner> runner = new MessageLoopRunner; 121 scoped_refptr<MessageLoopRunner> runner = new MessageLoopRunner;
123 LocalTwoPhaseTestServer test_server; 122 LocalTwoPhaseTestServer test_server;
124 ASSERT_TRUE(test_server.Start()); 123 ASSERT_TRUE(test_server.Start());
125 Delegate delegate; 124 Delegate delegate;
126 std::unique_ptr<TwoPhaseUploader> uploader(TwoPhaseUploader::Create( 125 std::unique_ptr<TwoPhaseUploader> uploader(TwoPhaseUploader::Create(
127 url_request_context_getter_.get(), 126 url_request_context_getter_.get(),
128 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB).get(), 127 BrowserThread::GetTaskRunnerForThread(BrowserThread::DB).get(),
129 test_server.GetURL("start?p2code=500"), "metadata", GetTestFilePath(), 128 test_server.GetURL("start?p2code=500"), "metadata", GetTestFilePath(),
130 base::Bind(&Delegate::ProgressCallback, base::Unretained(&delegate)), 129 base::Bind(&Delegate::ProgressCallback, base::Unretained(&delegate)),
131 base::Bind(&Delegate::FinishCallback, base::Unretained(&delegate), 130 base::Bind(&Delegate::FinishCallback, base::Unretained(&delegate),
132 runner))); 131 runner)));
133 uploader->Start(); 132 uploader->Start();
134 runner->Run(); 133 runner->Run();
135 EXPECT_EQ(TwoPhaseUploader::UPLOAD_FILE, delegate.state_); 134 EXPECT_EQ(TwoPhaseUploader::UPLOAD_FILE, delegate.state_);
136 EXPECT_EQ(net::OK, delegate.net_error_); 135 EXPECT_EQ(net::OK, delegate.net_error_);
137 EXPECT_EQ(500, delegate.response_code_); 136 EXPECT_EQ(500, delegate.response_code_);
138 EXPECT_EQ( 137 EXPECT_EQ(
139 "/start\n" // path of start request 138 "/start\n" // path of start request
140 "4c24b2612e94e2ae622e54397663f2b7bf0a2e17\n" // sha1sum of "metadata" 139 "4c24b2612e94e2ae622e54397663f2b7bf0a2e17\n" // sha1sum of "metadata"
141 "944857cc626f2cafe232521986b4c6d3f9993c97\n", // sha1sum of test file 140 "944857cc626f2cafe232521986b4c6d3f9993c97\n", // sha1sum of test file
142 delegate.response_); 141 delegate.response_);
143 } 142 }
144 143
145 TEST_F(TwoPhaseUploaderTest, PhaseOneConnectionClosed) { 144 TEST_F(TwoPhaseUploaderTest, PhaseOneConnectionClosed) {
146 scoped_refptr<MessageLoopRunner> runner = new MessageLoopRunner; 145 scoped_refptr<MessageLoopRunner> runner = new MessageLoopRunner;
147 LocalTwoPhaseTestServer test_server; 146 LocalTwoPhaseTestServer test_server;
148 ASSERT_TRUE(test_server.Start()); 147 ASSERT_TRUE(test_server.Start());
149 Delegate delegate; 148 Delegate delegate;
150 std::unique_ptr<TwoPhaseUploader> uploader(TwoPhaseUploader::Create( 149 std::unique_ptr<TwoPhaseUploader> uploader(TwoPhaseUploader::Create(
151 url_request_context_getter_.get(), 150 url_request_context_getter_.get(),
152 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB).get(), 151 BrowserThread::GetTaskRunnerForThread(BrowserThread::DB).get(),
153 test_server.GetURL("start?p1close=1"), "metadata", GetTestFilePath(), 152 test_server.GetURL("start?p1close=1"), "metadata", GetTestFilePath(),
154 base::Bind(&Delegate::ProgressCallback, base::Unretained(&delegate)), 153 base::Bind(&Delegate::ProgressCallback, base::Unretained(&delegate)),
155 base::Bind(&Delegate::FinishCallback, base::Unretained(&delegate), 154 base::Bind(&Delegate::FinishCallback, base::Unretained(&delegate),
156 runner))); 155 runner)));
157 uploader->Start(); 156 uploader->Start();
158 runner->Run(); 157 runner->Run();
159 EXPECT_EQ(TwoPhaseUploader::UPLOAD_METADATA, delegate.state_); 158 EXPECT_EQ(TwoPhaseUploader::UPLOAD_METADATA, delegate.state_);
160 EXPECT_EQ(net::ERR_EMPTY_RESPONSE, delegate.net_error_); 159 EXPECT_EQ(net::ERR_EMPTY_RESPONSE, delegate.net_error_);
161 EXPECT_EQ(net::URLFetcher::RESPONSE_CODE_INVALID, delegate.response_code_); 160 EXPECT_EQ(net::URLFetcher::RESPONSE_CODE_INVALID, delegate.response_code_);
162 EXPECT_EQ("", delegate.response_); 161 EXPECT_EQ("", delegate.response_);
163 } 162 }
164 163
165 TEST_F(TwoPhaseUploaderTest, PhaseTwoConnectionClosed) { 164 TEST_F(TwoPhaseUploaderTest, PhaseTwoConnectionClosed) {
166 scoped_refptr<MessageLoopRunner> runner = new MessageLoopRunner; 165 scoped_refptr<MessageLoopRunner> runner = new MessageLoopRunner;
167 LocalTwoPhaseTestServer test_server; 166 LocalTwoPhaseTestServer test_server;
168 ASSERT_TRUE(test_server.Start()); 167 ASSERT_TRUE(test_server.Start());
169 Delegate delegate; 168 Delegate delegate;
170 std::unique_ptr<TwoPhaseUploader> uploader(TwoPhaseUploader::Create( 169 std::unique_ptr<TwoPhaseUploader> uploader(TwoPhaseUploader::Create(
171 url_request_context_getter_.get(), 170 url_request_context_getter_.get(),
172 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB).get(), 171 BrowserThread::GetTaskRunnerForThread(BrowserThread::DB).get(),
173 test_server.GetURL("start?p2close=1"), "metadata", GetTestFilePath(), 172 test_server.GetURL("start?p2close=1"), "metadata", GetTestFilePath(),
174 base::Bind(&Delegate::ProgressCallback, base::Unretained(&delegate)), 173 base::Bind(&Delegate::ProgressCallback, base::Unretained(&delegate)),
175 base::Bind(&Delegate::FinishCallback, base::Unretained(&delegate), 174 base::Bind(&Delegate::FinishCallback, base::Unretained(&delegate),
176 runner))); 175 runner)));
177 uploader->Start(); 176 uploader->Start();
178 runner->Run(); 177 runner->Run();
179 EXPECT_EQ(TwoPhaseUploader::UPLOAD_FILE, delegate.state_); 178 EXPECT_EQ(TwoPhaseUploader::UPLOAD_FILE, delegate.state_);
180 EXPECT_EQ(net::ERR_EMPTY_RESPONSE, delegate.net_error_); 179 EXPECT_EQ(net::ERR_EMPTY_RESPONSE, delegate.net_error_);
181 EXPECT_EQ(net::URLFetcher::RESPONSE_CODE_INVALID, delegate.response_code_); 180 EXPECT_EQ(net::URLFetcher::RESPONSE_CODE_INVALID, delegate.response_code_);
182 EXPECT_EQ("", delegate.response_); 181 EXPECT_EQ("", delegate.response_);
183 } 182 }
184 183
185 } // namespace safe_browsing 184 } // namespace safe_browsing
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/srt_fetcher_win.cc ('k') | chrome/browser/safe_browsing/ui_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698