Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: PRESUBMIT.py

Issue 2133083002: Remove all remaining traces of MessageLoopProxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | android_webview/browser/aw_browser_context.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 ( 271 (
272 'Do not introduce new v8::Extensions into the code base, use', 272 'Do not introduce new v8::Extensions into the code base, use',
273 'gin::Wrappable instead. See http://crbug.com/334679', 273 'gin::Wrappable instead. See http://crbug.com/334679',
274 ), 274 ),
275 True, 275 True,
276 ( 276 (
277 r'extensions[\\\/]renderer[\\\/]safe_builtins\.*', 277 r'extensions[\\\/]renderer[\\\/]safe_builtins\.*',
278 ), 278 ),
279 ), 279 ),
280 ( 280 (
281 '\<MessageLoopProxy\>',
282 (
283 'MessageLoopProxy is deprecated. ',
284 'Please use SingleThreadTaskRunner or ThreadTaskRunnerHandle instead.'
285 ),
286 True,
287 (
288 # Internal message_loop related code may still use it.
289 r'^base[\\\/]message_loop[\\\/].*',
290 ),
291 ),
292 (
293 '#pragma comment(lib,', 281 '#pragma comment(lib,',
294 ( 282 (
295 'Specify libraries to link with in build files and not in the source.', 283 'Specify libraries to link with in build files and not in the source.',
296 ), 284 ),
297 True, 285 True,
298 (), 286 (),
299 ), 287 ),
300 ) 288 )
301 289
302 290
(...skipping 1923 matching lines...) Expand 10 before | Expand all | Expand 10 after
2226 results.extend(input_api.canned_checks.CheckTreeIsOpen( 2214 results.extend(input_api.canned_checks.CheckTreeIsOpen(
2227 input_api, 2215 input_api,
2228 output_api, 2216 output_api,
2229 json_url='http://chromium-status.appspot.com/current?format=json')) 2217 json_url='http://chromium-status.appspot.com/current?format=json'))
2230 2218
2231 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2219 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2232 input_api, output_api)) 2220 input_api, output_api))
2233 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2221 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2234 input_api, output_api)) 2222 input_api, output_api))
2235 return results 2223 return results
OLDNEW
« no previous file with comments | « no previous file | android_webview/browser/aw_browser_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698