|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by fukino Modified:
4 years, 5 months ago Reviewers:
Dan Beam CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionStorage manager: Show "0 B" as the total size of other users when there is no other user.
BUG=626560
TEST=manually tested
Committed: https://crrev.com/d1cbc12d9800e4032a628d6f67faab7109cd4283
Cr-Commit-Position: refs/heads/master@{#404974}
Patch Set 1 #Patch Set 2 : Rebase #Messages
Total messages: 26 (12 generated)
fukino@chromium.org changed reviewers: + achuith@chromium.org
Hi achuith@, could you take a look? Thanks!
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Could you look in the revision log of this file and find a more suitable reviewer? I don't know much about this class
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/07/08 11:36:58, achuithb wrote: > Could you look in the revision log of this file and find a more suitable > reviewer? I don't know much about this class Sorry! I'm the only author in the revision log, so I wanted a reviewer from the OWNERS. I'll ask dbeam@ who reviewed previous CLs.
fukino@chromium.org changed reviewers: + dbeam@chromium.org - achuith@chromium.org
Dan, could you take a look?
lgtm
Thank you!
The CQ bit was checked by fukino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fukino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fukino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Storage manager: Show "0 B" as the total size of other users when there is no other user. BUG=626560 TEST=manually tested ========== to ========== Storage manager: Show "0 B" as the total size of other users when there is no other user. BUG=626560 TEST=manually tested Committed: https://crrev.com/d1cbc12d9800e4032a628d6f67faab7109cd4283 Cr-Commit-Position: refs/heads/master@{#404974} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d1cbc12d9800e4032a628d6f67faab7109cd4283 Cr-Commit-Position: refs/heads/master@{#404974} |
