Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2133063002: Storage manager: Show "0 B" as the total size of other users when there is no other user. (Closed)

Created:
4 years, 5 months ago by fukino
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Storage manager: Show "0 B" as the total size of other users when there is no other user. BUG=626560 TEST=manually tested Committed: https://crrev.com/d1cbc12d9800e4032a628d6f67faab7109cd4283 Cr-Commit-Position: refs/heads/master@{#404974}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
fukino
Hi achuith@, could you take a look? Thanks!
4 years, 5 months ago (2016-07-08 08:04:26 UTC) #2
achuithb
Could you look in the revision log of this file and find a more suitable ...
4 years, 5 months ago (2016-07-08 11:36:58 UTC) #5
fukino
On 2016/07/08 11:36:58, achuithb wrote: > Could you look in the revision log of this ...
4 years, 5 months ago (2016-07-11 05:21:50 UTC) #8
fukino
Dan, could you take a look?
4 years, 5 months ago (2016-07-11 05:22:15 UTC) #10
Dan Beam
lgtm
4 years, 5 months ago (2016-07-12 02:12:05 UTC) #11
fukino
Thank you!
4 years, 5 months ago (2016-07-12 02:13:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133063002/20001
4 years, 5 months ago (2016-07-12 02:14:56 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260577)
4 years, 5 months ago (2016-07-12 03:39:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133063002/20001
4 years, 5 months ago (2016-07-12 04:02:55 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242362)
4 years, 5 months ago (2016-07-12 06:55:07 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133063002/20001
4 years, 5 months ago (2016-07-13 02:34:58 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 03:42:47 UTC) #23
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 03:42:57 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 03:44:14 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1cbc12d9800e4032a628d6f67faab7109cd4283
Cr-Commit-Position: refs/heads/master@{#404974}

Powered by Google App Engine
This is Rietveld 408576698