Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2133043002: Get rid of redundant console.assert() from Serializer in assert_selection() (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Serializer in assert_selection() not to use anchor/focus of empty selection This patch changes |Serializer| class in |assert_selection()| not to use anchor/focus positions of empty selection to avoid |console.assert()| in |SampleSelection| getters. This is follow-up patch for http://crrev.com/403433, which makes |assert_selection()| to support empty selection result. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/aa7398f8acc1ae458df91be30a0cc335a0279b1c Cr-Commit-Position: refs/heads/master@{#405730}

Patch Set 1 : 2016-07-08T16:37:37 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/editing/assert_selection.js View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-15 07:09:34 UTC) #4
yoichio
lgtm
4 years, 5 months ago (2016-07-15 07:30:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133043002/1
4 years, 5 months ago (2016-07-15 08:20:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 09:27:11 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 09:27:23 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 09:28:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa7398f8acc1ae458df91be30a0cc335a0279b1c
Cr-Commit-Position: refs/heads/master@{#405730}

Powered by Google App Engine
This is Rietveld 408576698