ui/views/controls/menu/menu_runner_cocoa_unittest.mm - Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_runner_cocoa_unittest.mm

Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix overrides on Mac and Chrome OS. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/menu/menu_runner_cocoa_unittest.mm

diff --git a/ui/views/controls/menu/menu_runner_cocoa_unittest.mm b/ui/views/controls/menu/menu_runner_cocoa_unittest.mm

index 09449d24c86170d83f58391c7cbc0585db523479..b9a66567938162c93fb24e1a9ed7073787914f22 100644

--- a/ui/views/controls/menu/menu_runner_cocoa_unittest.mm

+++ b/ui/views/controls/menu/menu_runner_cocoa_unittest.mm

@@ -35,8 +35,9 @@ class TestModel : public ui::SimpleMenuModel {

return command_id == model_->checked_command_;

}

bool IsCommandIdEnabled(int command_id) const override { return true; }

- bool GetAcceleratorForCommandId(int command_id,

- ui::Accelerator* accelerator) override {

+ bool GetAcceleratorForCommandId(

+ int command_id,

+ ui::Accelerator* accelerator) const override {

return false;

}

void ExecuteCommand(int command_id, int event_flags) override {}

« no previous file with comments | « ui/message_center/views/notifier_settings_view.cc ('k') | ui/views/controls/textfield/textfield.h » ('j') | no next file with comments »