ui/base/models/button_menu_item_model.h - Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/models/button_menu_item_model.h

Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix overrides on Mac and Chrome OS. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/models/button_menu_item_model.h

diff --git a/ui/base/models/button_menu_item_model.h b/ui/base/models/button_menu_item_model.h

index 9c78b5986c84f1a83a89ed8d8a80a12e9eaf9803..efe3f8f02de8649394790ce335898e3316576a3d 100644

--- a/ui/base/models/button_menu_item_model.h

+++ b/ui/base/models/button_menu_item_model.h

@@ -39,8 +39,9 @@ class UI_BASE_EXPORT ButtonMenuItemModel {

// Gets the accelerator for the specified command id. Returns true if the

// command id has a valid accelerator, false otherwise.

- virtual bool GetAcceleratorForCommandId(int command_id,

- ui::Accelerator* accelerator) = 0;

+ virtual bool GetAcceleratorForCommandId(

+ int command_id,

+ ui::Accelerator* accelerator) const = 0;

protected:

virtual ~Delegate() {}

« no previous file with comments | « ui/base/cocoa/menu_controller_unittest.mm ('k') | ui/base/models/simple_menu_model.h » ('j') | no next file with comments »