content/shell/browser/shell_views.cc - Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_views.cc

Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix overrides on Mac and Chrome OS. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/browser/shell_views.cc

diff --git a/content/shell/browser/shell_views.cc b/content/shell/browser/shell_views.cc

index e8e45522b14677f9e7b7d75f60f1ce5ae06fb3e5..5dcc7751898e188bc62f0245475fa3b1bafdc8d2 100644

--- a/content/shell/browser/shell_views.cc

+++ b/content/shell/browser/shell_views.cc

@@ -71,7 +71,7 @@ class ContextMenuModel : public ui::SimpleMenuModel,

bool IsCommandIdChecked(int command_id) const override { return false; }

bool IsCommandIdEnabled(int command_id) const override { return true; }

bool GetAcceleratorForCommandId(int command_id,

- ui::Accelerator* accelerator) override {

+ ui::Accelerator* accelerator) const override {

return false;

}

void ExecuteCommand(int command_id, int event_flags) override {

« no previous file with comments | « components/translate/core/browser/options_menu_model.cc ('k') | ui/app_list/app_list_menu.h » ('j') | no next file with comments »