chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc - Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix overrides on Mac and Chrome OS. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_editor_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

index dac903726b62440c3add3ef6d5349b5f42fc1bb8..9e478df230c4eddee4f5f84751f1290a52642d97 100644

--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

@@ -252,7 +252,8 @@ bool RecentTabsSubMenuModel::IsCommandIdEnabled(int command_id) const {

}

bool RecentTabsSubMenuModel::GetAcceleratorForCommandId(

- int command_id, ui::Accelerator* accelerator) {

+ int command_id,

+ ui::Accelerator* accelerator) const {

// If there are no recently closed items, we show the accelerator beside

// the header, otherwise, we show it beside the first item underneath it.

int index_in_menu = GetIndexOfCommandId(command_id);

« no previous file with comments | « chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_editor_view.h » ('j') | no next file with comments »