chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm - Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm

Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix overrides on Mac and Chrome OS. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc ('k') | chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm

diff --git a/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm b/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm

index 36818e2b1e9044e8f0f4da1aaf2a6a6165966254..bc4f35fb06a26f4ae2796b799ab01a972e1f1278 100644

--- a/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm

+++ b/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm

@@ -79,8 +79,9 @@ namespace AppMenuControllerInternal {

// A C++ delegate that handles the accelerators in the app menu.

class AcceleratorDelegate : public ui::AcceleratorProvider {

public:

- bool GetAcceleratorForCommandId(int command_id,

- ui::Accelerator* out_accelerator) override {

+ bool GetAcceleratorForCommandId(

+ int command_id,

+ ui::Accelerator* out_accelerator) const override {

AcceleratorsCocoa* keymap = AcceleratorsCocoa::GetInstance();

const ui::Accelerator* accelerator =

keymap->GetAcceleratorForCommand(command_id);