ash/sysui/shelf_delegate_mus.cc - Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/sysui/shelf_delegate_mus.cc

Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix overrides on Mac and Chrome OS. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/sysui/shelf_delegate_mus.cc

diff --git a/ash/sysui/shelf_delegate_mus.cc b/ash/sysui/shelf_delegate_mus.cc

index 773a9ad121708ef3190c9176dddeb07ca248c334..a1c229dc68e004e8109a97b22f1a7f8376861d10 100644

--- a/ash/sysui/shelf_delegate_mus.cc

+++ b/ash/sysui/shelf_delegate_mus.cc

@@ -89,8 +89,9 @@ class ShelfItemDelegateMus : public ShelfItemDelegate {

bool IsCommandIdEnabled(int command_id) const override {

return command_id > 0;

}

- bool GetAcceleratorForCommandId(int command_id,

- ui::Accelerator* accelerator) override {

+ bool GetAcceleratorForCommandId(

+ int command_id,

+ ui::Accelerator* accelerator) const override {

return false;

}

void ExecuteCommand(int command_id, int event_flags) override {

« no previous file with comments | « ash/sysui/context_menu_mus.cc ('k') | chrome/browser/apps/app_browsertest.cc » ('j') | no next file with comments »