Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: chrome/browser/extensions/extension_context_menu_model.cc

Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix overrides on Mac and Chrome OS. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_context_menu_model.h" 5 #include "chrome/browser/extensions/extension_context_menu_model.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/app/chrome_command_ids.h" 9 #include "chrome/app/chrome_command_ids.h"
10 #include "chrome/browser/extensions/context_menu_matcher.h" 10 #include "chrome/browser/extensions/context_menu_matcher.h"
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 case PAGE_ACCESS_RUN_ON_SITE: 221 case PAGE_ACCESS_RUN_ON_SITE:
222 case PAGE_ACCESS_RUN_ON_ALL_SITES: 222 case PAGE_ACCESS_RUN_ON_ALL_SITES:
223 return true; 223 return true;
224 default: 224 default:
225 NOTREACHED() << "Unknown command" << command_id; 225 NOTREACHED() << "Unknown command" << command_id;
226 } 226 }
227 return true; 227 return true;
228 } 228 }
229 229
230 bool ExtensionContextMenuModel::GetAcceleratorForCommandId( 230 bool ExtensionContextMenuModel::GetAcceleratorForCommandId(
231 int command_id, ui::Accelerator* accelerator) { 231 int command_id,
232 ui::Accelerator* accelerator) const {
232 return false; 233 return false;
233 } 234 }
234 235
235 void ExtensionContextMenuModel::ExecuteCommand(int command_id, 236 void ExtensionContextMenuModel::ExecuteCommand(int command_id,
236 int event_flags) { 237 int event_flags) {
237 const Extension* extension = GetExtension(); 238 const Extension* extension = GetExtension();
238 if (!extension) 239 if (!extension)
239 return; 240 return;
240 241
241 if (command_id >= IDC_EXTENSIONS_CONTEXT_CUSTOM_FIRST && 242 if (command_id >= IDC_EXTENSIONS_CONTEXT_CUSTOM_FIRST &&
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 if (runner && runner->WantsToRun(extension)) 461 if (runner && runner->WantsToRun(extension))
461 runner->RunBlockedActions(extension); 462 runner->RunBlockedActions(extension);
462 } 463 }
463 } 464 }
464 465
465 content::WebContents* ExtensionContextMenuModel::GetActiveWebContents() const { 466 content::WebContents* ExtensionContextMenuModel::GetActiveWebContents() const {
466 return browser_->tab_strip_model()->GetActiveWebContents(); 467 return browser_->tab_strip_model()->GetActiveWebContents();
467 } 468 }
468 469
469 } // namespace extensions 470 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model.h ('k') | chrome/browser/media_galleries/media_gallery_context_menu.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698