Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 21330: Enable --single-process for Mac and Linux.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by Scott Hess - ex-Googler
Modified:
6 years, 3 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enable --single-process for Mac and Linux. Additionally, wire in a bit of setup for the --single-process case, because it cannot be done by the renderer thread because that thread is not the main thread. Fair warning: --single-process often seems to be broken by various unrelated changes, which may-or-may-not make assumptions about the process architecture. I will try to stay on top of these. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10559

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M chrome/app/chrome_dll_main.cc View 1 2 3 4 5 6 7 8 3 chunks +12 lines, -4 lines 0 comments Download
M chrome/renderer/renderer_main_platform_delegate_mac.mm View 8 1 chunk +3 lines, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 11 (0 generated)
Scott Hess - ex-Googler
With this change, I still get a crash in WebViewImpl::DownloadImage(), unless I patch in an ...
8 years, 7 months ago (2009-02-13 01:04:44 UTC) #1
John Grabowski
I'll come talk about the DownloadImage() problem. http://codereview.chromium.org/21330/diff/1/2 File chrome/app/chrome_dll_main.cc (right): http://codereview.chromium.org/21330/diff/1/2#newcode287 Line 287: InitWebCoreSystemInterface(); ...
8 years, 7 months ago (2009-02-13 01:13:06 UTC) #2
John Grabowski
http://codereview.chromium.org/21330/diff/1/3 File chrome/renderer/render_thread.cc (left): http://codereview.chromium.org/21330/diff/1/3#oldcode241 Line 241: #if defined(OS_MACOSX) On 2009/02/13 01:13:06, John Grabowski wrote: ...
8 years, 7 months ago (2009-02-13 01:22:28 UTC) #3
Scott Hess - ex-Googler
OK, John, after browsing around about how things are used, I think I understand your ...
8 years, 7 months ago (2009-02-13 19:41:44 UTC) #4
jeremy
http://codereview.chromium.org/21330/diff/1005/11 File chrome/app/chrome_dll_main.cc (right): http://codereview.chromium.org/21330/diff/1005/11#newcode319 Line 319: } Does this work on Windows? My only ...
8 years, 7 months ago (2009-02-13 20:32:32 UTC) #5
Scott Hess - ex-Googler
Carlos says no for Windows, which means it will need refactoring. I think the distinction ...
8 years, 7 months ago (2009-02-13 21:08:56 UTC) #6
Scott Hess - ex-Googler
Look again? This is really ugly. I'm starting to wish for a simple #ifdef in ...
8 years, 7 months ago (2009-02-13 23:21:03 UTC) #7
jeremy
http://codereview.chromium.org/21330/diff/1007/20 File chrome/renderer/renderer_main_platform_delegate.h (right): http://codereview.chromium.org/21330/diff/1007/20#newcode30 Line 30: // the sandbox. Do not call if not ...
8 years, 7 months ago (2009-02-13 23:34:43 UTC) #8
Scott Hess - ex-Googler
I put up a new CL to look at while I try to get Windows ...
8 years, 7 months ago (2009-02-14 00:09:05 UTC) #9
John Grabowski
I like it, so long as Windows still works. Thanks for following up Scott. LGTM
8 years, 7 months ago (2009-02-17 18:51:21 UTC) #10
Scott Hess - ex-Googler
8 years, 7 months ago (2009-02-19 20:26:57 UTC) #11
I should get this out of my client so I can move on.  John and Jeremy are OOO.

The story is, this is where I started with things, John thought I should try to
use RendererMainPlatformDelegate instead so that we wouldn't miss out on other
essential start-up stuff, worked that around for awhile, then finally found that
DEPS forbids that dependency (and it didn't show up anywhere but Linux, and even
there it didn't fail earlier).  So, now I'm back to square one, and using TODO()
to fill in for refactoring.

With this, you can use it as a browser pretty successfully.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b