Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Unified Diff: runtime/vm/assembler_arm_test.cc

Issue 2132933003: VM: Remove collection of unused range feedback. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: remove comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm64_test.cc ('k') | runtime/vm/assembler_ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm_test.cc
diff --git a/runtime/vm/assembler_arm_test.cc b/runtime/vm/assembler_arm_test.cc
index 1e6e6efb67f10d859b9893f62bf8a8ab9c2edee9..7eca350b721da2ef5c5758efac7c2a076eaf9c05 100644
--- a/runtime/vm/assembler_arm_test.cc
+++ b/runtime/vm/assembler_arm_test.cc
@@ -3961,58 +3961,6 @@ ASSEMBLER_TEST_GENERATE(StoreIntoObject, assembler) {
__ Ret();
}
-
-ASSEMBLER_TEST_GENERATE(ComputeRange, assembler) {
- Label miss, done;
- __ mov(R1, Operand(R0));
- __ ComputeRange(R0, R1, R2, &miss);
- __ b(&done);
-
- __ Bind(&miss);
- __ LoadImmediate(R0, -1);
-
- __ Bind(&done);
- __ Ret();
-}
-
-
-ASSEMBLER_TEST_RUN(ComputeRange, test) {
- typedef intptr_t (*ComputeRange)(intptr_t value) DART_UNUSED;
-
-#define RANGE_OF(v) \
- (EXECUTE_TEST_CODE_INTPTR_INTPTR( \
- ComputeRange, test->entry(), reinterpret_cast<intptr_t>(v)))
-
- EXPECT_EQ(0, RANGE_OF(Smi::New(0)));
- EXPECT_EQ(0, RANGE_OF(Smi::New(1)));
- EXPECT_EQ(ICData::kSignedRangeBit, RANGE_OF(Smi::New(-1)));
- EXPECT_EQ(0, RANGE_OF(Smi::New(Smi::kMaxValue)));
- EXPECT_EQ(ICData::kSignedRangeBit, RANGE_OF(Smi::New(Smi::kMinValue)));
-
- EXPECT_EQ(ICData::kInt32RangeBit, RANGE_OF(Integer::New(Smi::kMaxValue + 1)));
- EXPECT_EQ(ICData::kInt32RangeBit | ICData::kSignedRangeBit,
- RANGE_OF(Integer::New(Smi::kMinValue - 1)));
- EXPECT_EQ(ICData::kInt32RangeBit, RANGE_OF(Integer::New(kMaxInt32)));
- EXPECT_EQ(ICData::kInt32RangeBit | ICData::kSignedRangeBit,
- RANGE_OF(Integer::New(kMinInt32)));
-
- EXPECT_EQ(ICData::kUint32RangeBit,
- RANGE_OF(Integer::New(static_cast<int64_t>(kMaxInt32) + 1)));
- EXPECT_EQ(ICData::kUint32RangeBit,
- RANGE_OF(Integer::New(kMaxUint32)));
-
- EXPECT_EQ(ICData::kInt64RangeBit,
- RANGE_OF(Integer::New(static_cast<int64_t>(kMaxUint32) + 1)));
- EXPECT_EQ(ICData::kInt64RangeBit,
- RANGE_OF(Integer::New(static_cast<int64_t>(kMinInt32) - 1)));
- EXPECT_EQ(ICData::kInt64RangeBit, RANGE_OF(Integer::New(kMaxInt64)));
- EXPECT_EQ(ICData::kInt64RangeBit, RANGE_OF(Integer::New(kMinInt64)));
-
- EXPECT_EQ(-1, RANGE_OF(Bool::True().raw()));
-
-#undef RANGE_OF
-}
-
} // namespace dart
#endif // defined TARGET_ARCH_ARM
« no previous file with comments | « runtime/vm/assembler_arm64_test.cc ('k') | runtime/vm/assembler_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698