remoting/client/jni/jni_gl_display_handler.cc - Issue 2132883002: [Remoting Android] Placeholder for DesktopView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/jni/jni_gl_display_handler.cc

Issue 2132883002: [Remoting Android] Placeholder for DesktopView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase ToT and do same fix for GlDisplay Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/jni/jni_gl_display_handler.cc

diff --git a/remoting/client/jni/jni_gl_display_handler.cc b/remoting/client/jni/jni_gl_display_handler.cc

index ed76aff64f6a1f46430ee8bd13bba8011ed82053..20e24e92f66e62e86b2ac0c23e5ab6c9396323bf 100644

--- a/remoting/client/jni/jni_gl_display_handler.cc

+++ b/remoting/client/jni/jni_gl_display_handler.cc

@@ -24,8 +24,9 @@ JniGlDisplayHandler::~JniGlDisplayHandler() {

}

base::android::ScopedJavaLocalRef<jobject>

-JniGlDisplayHandler::GetJavaDisplay() {

- return base::android::ScopedJavaLocalRef<jobject>(java_display_);

+JniGlDisplayHandler::CreateDesktopViewFactory() {

+ return Java_GlDisplay_createDesktopViewFactory(

+ base::android::AttachCurrentThread(), java_display_.obj());

}

std::unique_ptr<protocol::CursorShapeStub>