remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java - Issue 2132883002: [Remoting Android] Placeholder for DesktopView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java

Issue 2132883002: [Remoting Android] Placeholder for DesktopView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase ToT and do same fix for GlDisplay Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/android/java/src/org/chromium/chromoting/DesktopView.java ('K') | « remoting/android/java/src/org/chromium/chromoting/cardboard/Cursor.java ('k') | remoting/android/java/src/org/chromium/chromoting/jni/Client.java » ('j') | remoting/android/java/src/org/chromium/chromoting/jni/Client.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java

diff --git a/remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java b/remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java

index e5ac3babc693be38ff369292a238441a2f1fd178..8f42c4ae9156707c9c7acc748ff67d96021ec49b 100644

--- a/remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java

+++ b/remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java

@@ -44,7 +44,11 @@ public class DesktopActivity extends CardboardActivity {

mSwitchToDesktopActivity = false;

CardboardView cardboardView = (CardboardView) findViewById(R.id.cardboard_view);

- mRenderer = new CardboardRenderer(this, mClient);

+ // THE CODE BELOW IS BROKEN.

+ // To make it work, you have to somehow get the reference to the Display object and pass

+ // it into the constructor.

+ mRenderer = new CardboardRenderer(this, mClient, null);

mIsListening = false;

// Associate a CardboardView.StereoRenderer with cardboard view.