Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/Desktop.java

Issue 2132883002: [Remoting Android] Placeholder for DesktopView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase ToT and do same fix for GlDisplay Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/Desktop.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/Desktop.java b/remoting/android/java/src/org/chromium/chromoting/Desktop.java
index 4ad4324d816408f6fb351b04a96647f7a5e4ec69..d328a03016c5f37d74dce42650dca1635c4295f8 100644
--- a/remoting/android/java/src/org/chromium/chromoting/Desktop.java
+++ b/remoting/android/java/src/org/chromium/chromoting/Desktop.java
@@ -24,6 +24,7 @@ import android.view.MotionEvent;
import android.view.View;
import android.view.View.OnLayoutChangeListener;
import android.view.View.OnTouchListener;
+import android.view.ViewGroup;
import android.view.inputmethod.InputMethodManager;
import org.chromium.chromoting.cardboard.DesktopActivity;
@@ -104,7 +105,10 @@ public class Desktop
mToolbar = (Toolbar) findViewById(R.id.toolbar);
setSupportActionBar(mToolbar);
- DesktopView remoteHostDesktop = (DesktopView) findViewById(R.id.desktop_view);
+ AbstractDesktopView remoteHostDesktop = mClient.createDesktopView(this);
+ remoteHostDesktop.setLayoutParams(new ViewGroup.LayoutParams(
+ ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.MATCH_PARENT));
+ ((ViewGroup) findViewById(R.id.desktop_view_placeholder)).addView(remoteHostDesktop);
remoteHostDesktop.init(this, mClient);
mSwitchToCardboardDesktopActivity = false;
@@ -163,8 +167,6 @@ public class Desktop
super.onStart();
mActivityLifecycleListener.onActivityStarted(this);
mClient.enableVideoChannel(true);
- DesktopView desktopView = (DesktopView) findViewById(R.id.desktop_view);
- desktopView.attachRedrawCallback();
mClient.getCapabilityManager().addListener(this);
}

Powered by Google App Engine
This is Rietveld 408576698