runtime/platform/assert.cc - Issue 2132833002: Make core snapshot word-size portable again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/platform/assert.cc

Issue 2132833002: Make core snapshot word-size portable again. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: no size classes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/platform/assert.cc

diff --git a/runtime/platform/assert.cc b/runtime/platform/assert.cc

index c5b91e714f3bbb6c4a1ea6c73c56b562a38ffab4..ff71e3f78c8cefb827bfb0419fee4cb8fe02d668 100644

--- a/runtime/platform/assert.cc

+++ b/runtime/platform/assert.cc

@@ -34,9 +34,8 @@ void DynamicAssertionHelper::Fail(const char* format, ...) {

arguments);

va_end(arguments);

- // Print the buffer on stderr.

- fprintf(stderr, "%s\n", buffer);

- fflush(stderr);

+ // Print the buffer on stderr and/or syslog.

+ OS::PrintErr("%s\n", buffer);

// In case of failed assertions, abort right away. Otherwise, wait

// until the program is exiting before producing a non-zero exit

« no previous file with comments | « no previous file | runtime/vm/clustered_snapshot.h » ('j') | runtime/vm/clustered_snapshot.cc » ('J')