Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 213283003: Move splice frame setting to ChunkDemuxer(). Disable for now. (Closed)

Created:
6 years, 9 months ago by DaleCurtis
Modified:
6 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Move splice frame setting to ChunkDemuxer(). Disable for now. Splice frames are only supported by AudioRendererImpl currently, so we need to make sure other platforms like Android, etc don't enable splice frames until they're supported there. Also, splice frames have some bugs which need fixing, so disable on all platforms for now. BUG=356073, 356545 TEST=splice frames still work. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259801

Patch Set 1 #

Patch Set 2 : Constructor. #

Patch Set 3 : Disable android. Fix const. #

Patch Set 4 : Default off everywhere. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -41 lines) Patch
M content/renderer/media/android/media_source_delegate.cc View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M media/filters/chunk_demuxer.h View 1 2 4 chunks +10 lines, -2 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 1 7 chunks +18 lines, -11 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M media/filters/source_buffer_stream.h View 1 2 chunks +9 lines, -3 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 1 5 chunks +14 lines, -8 lines 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
DaleCurtis
6 years, 9 months ago (2014-03-26 20:29:34 UTC) #1
acolwell GONE FROM CHROMIUM
After looking at these changes and further thought, I think we should just pass this ...
6 years, 9 months ago (2014-03-26 20:40:36 UTC) #2
DaleCurtis
No problem. Done.
6 years, 9 months ago (2014-03-26 21:19:03 UTC) #3
acolwell GONE FROM CHROMIUM
lgtm
6 years, 9 months ago (2014-03-26 23:07:53 UTC) #4
DaleCurtis
I changed this to disable in WebMediaPlayerImpl, PipelineIntegrationTest, and ChunkDemuxer for now since the other ...
6 years, 9 months ago (2014-03-27 00:18:11 UTC) #5
acolwell GONE FROM CHROMIUM
On 2014/03/27 00:18:11, DaleCurtis wrote: > I changed this to disable in WebMediaPlayerImpl, PipelineIntegrationTest, and ...
6 years, 9 months ago (2014-03-27 00:26:27 UTC) #6
DaleCurtis
Just going to CQ this one, kareng has already cut :)
6 years, 9 months ago (2014-03-27 00:27:49 UTC) #7
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 9 months ago (2014-03-27 00:28:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/213283003/70001
6 years, 9 months ago (2014-03-27 00:34:15 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 05:49:30 UTC) #10
Message was sent while issue was closed.
Change committed as 259801

Powered by Google App Engine
This is Rietveld 408576698