Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 213283002: Make the default testharness.js timeout longer than the LayoutTests timeout (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Make the default testharness.js timeout longer than the LayoutTests timeout With the previous defaults, tests could timeout before the LayoutTests timeout, which would be reported as a failure. Making the timeout very long should fix tests that are flaky with the 2 second timeout and will make the SlowTests mechanism work for testharness.js tests, should the need arise. BUG=355489 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170136

Patch Set 1 #

Patch Set 2 : more testharness.js #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M LayoutTests/http/tests/resources/testharness.js View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/w3c/resources/testharness.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/resources/testharness.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
philipj_slow
Instead of https://codereview.chromium.org/209383013/
6 years, 9 months ago (2014-03-26 17:24:28 UTC) #1
acolwell GONE FROM CHROMIUM
If we do this, I think we should also update LayoutTests/http/tests/w3c/resources/testharness.js with the same values ...
6 years, 9 months ago (2014-03-26 17:54:31 UTC) #2
philipj_slow
Oh, I didn't realize we have multiple copies :) Will have to look into that ...
6 years, 9 months ago (2014-03-26 18:00:29 UTC) #3
acolwell GONE FROM CHROMIUM
On 2014/03/26 18:00:29, philipj wrote: > Oh, I didn't realize we have multiple copies :) ...
6 years, 9 months ago (2014-03-26 18:22:34 UTC) #4
Dirk Pranke
lgtm. whenever I (or someone else) gets around to fully integrating the http-requiring tests from ...
6 years, 9 months ago (2014-03-26 19:41:05 UTC) #5
philipj_slow
OK, I'll make the same edit to all testharness.js and give it a go then!
6 years, 9 months ago (2014-03-27 01:36:08 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-27 02:35:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/213283002/40001
6 years, 9 months ago (2014-03-27 02:35:21 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 02:45:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-27 02:45:57 UTC) #10
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-27 03:02:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/213283002/40001
6 years, 9 months ago (2014-03-27 03:02:10 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 03:45:27 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 03:45:27 UTC) #14
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-27 04:17:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/213283002/40001
6 years, 9 months ago (2014-03-27 04:17:50 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 05:19:52 UTC) #17
Message was sent while issue was closed.
Change committed as 170136

Powered by Google App Engine
This is Rietveld 408576698