build/android/adb_command_line.py - Issue 2132813002: Fix handling of absent flags file in adb_command_line.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/adb_command_line.py

Issue 2132813002: Fix handling of absent flags file in adb_command_line.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/adb_command_line.py

diff --git a/build/android/adb_command_line.py b/build/android/adb_command_line.py

index 72f42b6e61e6872394f385579504f018beb20316..e758b092a6438d6e9b5de36e5be744df21718b63 100755

--- a/build/android/adb_command_line.py

+++ b/build/android/adb_command_line.py

@@ -44,7 +44,7 @@ Otherwise: Writes command-line file.

def read_flags(device):

try:

return device.ReadFile(args.device_path, as_root=as_root).rstrip()

- except device_errors.AdbCommandFailedError:

+ except device_errors.CommandFailedError:

return '' # File might not exist.

descriptions = all_devices.pMap(lambda d: d.build_description).pGet(None)

« no previous file with comments | « no previous file | no next file » | no next file with comments »