Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2132813002: Fix handling of absent flags file in adb_command_line.py. (Closed)

Created:
4 years, 5 months ago by skobes
Modified:
4 years, 5 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, perezju
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix handling of absent flags file in adb_command_line.py. This broke in http://crrev.com/2044413002. BUG=626453 Committed: https://crrev.com/3d86ed8b58e1320c9bc8d200a225bfc06241f823 Cr-Commit-Position: refs/heads/master@{#404282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/adb_command_line.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
skobes
4 years, 5 months ago (2016-07-07 21:13:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132813002/1
4 years, 5 months ago (2016-07-07 21:16:59 UTC) #4
jbudorick
lgtm
4 years, 5 months ago (2016-07-07 21:17:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132813002/1
4 years, 5 months ago (2016-07-07 21:18:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-07 23:19:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132813002/1
4 years, 5 months ago (2016-07-07 23:25:47 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 00:49:00 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 00:49:04 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 00:52:14 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3d86ed8b58e1320c9bc8d200a225bfc06241f823
Cr-Commit-Position: refs/heads/master@{#404282}

Powered by Google App Engine
This is Rietveld 408576698