Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 2132803002: Megamorphic code cleanup. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc
index d837eb8a7b03559b4e8cc0495b4701a776ffaac3..9801f25551edc8b3144979267d77aa165f1206bd 100644
--- a/runtime/vm/stub_code_ia32.cc
+++ b/runtime/vm/stub_code_ia32.cc
@@ -2021,52 +2021,6 @@ void StubCode::GenerateOptimizedIdenticalWithNumberCheckStub(
}
-void StubCode::EmitMegamorphicLookup(Assembler* assembler) {
- __ LoadTaggedClassIdMayBeSmi(EAX, EBX);
- // EAX: class ID of the receiver (smi).
- __ movl(EDI, FieldAddress(ECX, MegamorphicCache::buckets_offset()));
- __ movl(EBX, FieldAddress(ECX, MegamorphicCache::mask_offset()));
- // EDI: cache buckets array.
- // EBX: mask.
- __ pushl(ECX); // Spill MegamorphicCache.
-
- // Compute the table index.
- ASSERT(MegamorphicCache::kSpreadFactor == 7);
- // Use leal and subl multiply with 7 == 8 - 1.
- __ leal(ECX, Address(EAX, TIMES_8, 0));
- __ subl(ECX, EAX);
- // ECX: probe.
-
- Label loop, update, load_target_function;
- __ jmp(&loop);
-
- __ Bind(&update);
- __ addl(ECX, Immediate(Smi::RawValue(1)));
- __ Bind(&loop);
- __ andl(ECX, EBX);
- const intptr_t base = Array::data_offset();
- // ECX is smi tagged, but table entries are two words, so TIMES_4.
- __ movl(EDX, FieldAddress(EDI, ECX, TIMES_4, base));
-
- ASSERT(kIllegalCid == 0);
- __ testl(EDX, EDX);
- __ j(ZERO, &load_target_function, Assembler::kNearJump);
- __ cmpl(EDX, EAX);
- __ j(NOT_EQUAL, &update, Assembler::kNearJump);
-
- __ Bind(&load_target_function);
- // Call the target found in the cache. For a class id match, this is a
- // proper target for the given name and arguments descriptor. If the
- // illegal class id was found, the target is a cache miss handler that can
- // be invoked as a normal Dart function.
- __ movl(EAX, FieldAddress(EDI, ECX, TIMES_4, base + kWordSize));
- __ popl(ECX); // Restore MegamorphicCache.
- __ movl(EDX,
- FieldAddress(ECX, MegamorphicCache::arguments_descriptor_offset()));
- __ movl(EBX, FieldAddress(EAX, Function::entry_point_offset()));
-}
-
-
// Called from megamorphic calls.
// EBX: receiver
// ECX: MegamorphicCache (preserved)
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698