Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2132803002: Megamorphic code cleanup. (Closed)

Created:
4 years, 5 months ago by bakster
Modified:
4 years, 5 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Megamorphic code cleanup. - Removed the flag use_megamorphic_stub and - Removed StubCode::EmitMegamorphicLookup (inlined version of megamorphic call). - Removed the null load in GenerateMegamorphicLookupStub for arm64 to match other platforms. BUG= R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/38898e0a9ad99c2409441665b6f41a3a7164a77f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -238 lines) Patch
M runtime/vm/flow_graph_compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_compiler_dbc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 2 chunks +1 line, -6 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M runtime/vm/stub_code.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 3 chunks +19 lines, -48 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 2 chunks +8 lines, -13 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 2 chunks +1 line, -49 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bakster
Please review
4 years, 5 months ago (2016-07-07 20:54:33 UTC) #2
Florian Schneider
lgtm
4 years, 5 months ago (2016-07-07 21:31:00 UTC) #3
bakster
4 years, 5 months ago (2016-07-07 21:34:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
38898e0a9ad99c2409441665b6f41a3a7164a77f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698