Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2132763002: Fix null aware generic invocation. (Closed)

Created:
4 years, 5 months ago by Leaf
Modified:
4 years, 5 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix null aware generic invoke #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M lib/runtime/dart_sdk.js View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/src/compiler/ast_builder.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M lib/src/compiler/code_generator.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M test/codegen/language/nullaware_opt_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Leaf
4 years, 5 months ago (2016-07-07 19:52:28 UTC) #2
Jacob
lgtm https://codereview.chromium.org/2132763002/diff/1/lib/src/compiler/code_generator.dart File lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/2132763002/diff/1/lib/src/compiler/code_generator.dart#newcode4306 lib/src/compiler/code_generator.dart:4306: invoke.typeArguments, invoke.argumentList.arguments); nit: use cascades. return AstBuilder.methodInvoke(newTarget, invoke.methodName, ...
4 years, 5 months ago (2016-07-07 20:00:19 UTC) #3
Leaf
https://codereview.chromium.org/2132763002/diff/1/lib/src/compiler/code_generator.dart File lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/2132763002/diff/1/lib/src/compiler/code_generator.dart#newcode4306 lib/src/compiler/code_generator.dart:4306: invoke.typeArguments, invoke.argumentList.arguments); On 2016/07/07 20:00:19, Jacob wrote: > nit: ...
4 years, 5 months ago (2016-07-07 20:07:05 UTC) #4
Leaf
Committed patchset #2 (id:20001) manually as f4898e3c1833f825a42da5797e6c49bd66123f0e (presubmit successful).
4 years, 5 months ago (2016-07-07 20:07:23 UTC) #6
Jennifer Messerly
4 years, 5 months ago (2016-07-11 16:43:42 UTC) #8
Message was sent while issue was closed.
LGTM!

Powered by Google App Engine
This is Rietveld 408576698