ui/login/account_picker/user_pod_row.js - Issue 2132753002: When pin-keyboard comes up the input element is of focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/login/account_picker/user_pod_row.js

Issue 2132753002: When pin-keyboard comes up the input element is of focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/login/account_picker/user_pod_row.js

diff --git a/ui/login/account_picker/user_pod_row.js b/ui/login/account_picker/user_pod_row.js

index c258be189f92761f2b8efd3a592195be78f04b0a..82be26187e827280e2e8dd6d2537c08ed282539c 100644

--- a/ui/login/account_picker/user_pod_row.js

+++ b/ui/login/account_picker/user_pod_row.js

@@ -1137,6 +1137,9 @@ cr.define('login', function() {

currentElement.classList.toggle('pin-enabled', visible);

currentElement.classList.toggle('pin-disabled', !visible);

}

+ // Set the focus to the input element after showing/hiding pin keyboard.

+ visible ? this.pinKeyboard.focus() : this.passwordElement.focus();

xiyuan 2016/07/07 20:01:40 nit: this.passwordElement.focus() -> this.mainInpu

jdufault 2016/07/07 20:46:50 Can you make this a regular if/else? if (visibl

sammiequon 2016/07/08 00:21:20 Done.

setUserPodIconType: function(userTypeClass) {

« no previous file with comments | « ui/login/account_picker/user_pod_row.css ('k') | ui/login/screen_container.css » ('j') | no next file with comments »