When pin-keyboard comes up the input element is of focus.

When pin-keyboard comes up the input element is of focus.

BUG=624190
Committed: https://crrev.com/4c8533dd7c1b9ac29add8014e6ace14a271e6418
Cr-Commit-Position: refs/heads/master@{#404300}

[sammiequon, 2016-07-07 19:53:43]

Description was changed from

==========
When pin-keyboard comes up the input element is of focus.

BUG=624190
==========

to

==========
When pin-keyboard comes up the input element is of focus.

BUG=624190
==========

[sammiequon, 2016-07-07 19:53:43]

sammiequon@chromium.org changed reviewers:
+ jdufault@chromium.org, xiyuan@chromium.org

[sammiequon, 2016-07-07 19:54:06]

jdufault@, xiyuan@ - Please take a look.

[xiyuan, 2016-07-07 20:01:41]

lgtm but please wait for jdufault

https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/use...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/use...
ui/login/account_picker/user_pod_row.js:1142: visible ? this.pinKeyboard.focus()
: this.passwordElement.focus();
nit: this.passwordElement.focus() -> this.mainInput.focus()

[jdufault, 2016-07-07 20:46:50]

lgtm after comment

https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/use...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/use...
ui/login/account_picker/user_pod_row.js:1142: visible ? this.pinKeyboard.focus()
: this.passwordElement.focus();
On 2016/07/07 20:01:40, xiyuan wrote:
> nit: this.passwordElement.focus() -> this.mainInput.focus()

Can you make this a regular if/else?

  if (visible)
    this.pinKeyboard.focus()
  else
    this.mainInput.focus()

[sammiequon, 2016-07-07 21:23:11]

The CQ bit was checked by sammiequon@chromium.org

[sammiequon, 2016-07-07 21:23:12]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
jdufault@chromium.org
Link to the patchset: https://codereview.chromium.org/2132753002/#ps20001
(title: "Fixed patch set 1 errors.")

[commit-bot: I haz the power, 2016-07-07 21:24:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 23:26:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 23:26:37]

Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)

[sammiequon, 2016-07-08 00:21:21]

https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/use...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/use...
ui/login/account_picker/user_pod_row.js:1142: visible ? this.pinKeyboard.focus()
: this.passwordElement.focus();
On 2016/07/07 20:01:40, xiyuan wrote:
> nit: this.passwordElement.focus() -> this.mainInput.focus()

Done.

https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/use...
ui/login/account_picker/user_pod_row.js:1142: visible ? this.pinKeyboard.focus()
: this.passwordElement.focus();
On 2016/07/07 20:46:50, jdufault wrote:
> On 2016/07/07 20:01:40, xiyuan wrote:
> > nit: this.passwordElement.focus() -> this.mainInput.focus()
> 
> Can you make this a regular if/else?
> 
>   if (visible)
>     this.pinKeyboard.focus()
>   else
>     this.mainInput.focus()

Done.

https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/use...
ui/login/account_picker/user_pod_row.js:1142: visible ? this.pinKeyboard.focus()
: this.passwordElement.focus();
On 2016/07/07 20:46:50, jdufault wrote:
> On 2016/07/07 20:01:40, xiyuan wrote:
> > nit: this.passwordElement.focus() -> this.mainInput.focus()
> 
> Can you make this a regular if/else?
> 
>   if (visible)
>     this.pinKeyboard.focus()
>   else
>     this.mainInput.focus()

Done.

[sammiequon, 2016-07-08 00:21:25]

The CQ bit was checked by sammiequon@chromium.org

[sammiequon, 2016-07-08 00:21:25]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
jdufault@chromium.org
Link to the patchset: https://codereview.chromium.org/2132753002/#ps40001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-07-08 00:21:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 01:23:32]

Description was changed from

==========
When pin-keyboard comes up the input element is of focus.

BUG=624190
==========

to

==========
When pin-keyboard comes up the input element is of focus.

BUG=624190
==========

[commit-bot: I haz the power, 2016-07-08 01:23:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-08 01:23:42]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 01:27:07]

Description was changed from

==========
When pin-keyboard comes up the input element is of focus.

BUG=624190
==========

to

==========
When pin-keyboard comes up the input element is of focus.

BUG=624190

Committed: https://crrev.com/4c8533dd7c1b9ac29add8014e6ace14a271e6418
Cr-Commit-Position: refs/heads/master@{#404300}
==========

[commit-bot: I haz the power, 2016-07-08 01:27:08]

Patchset 3 (id:??) landed as
https://crrev.com/4c8533dd7c1b9ac29add8014e6ace14a271e6418
Cr-Commit-Position: refs/heads/master@{#404300}