Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2132753002: When pin-keyboard comes up the input element is of focus. (Closed)

Created:
4 years, 5 months ago by sammiequon
Modified:
4 years, 5 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When pin-keyboard comes up the input element is of focus. BUG=624190 Committed: https://crrev.com/4c8533dd7c1b9ac29add8014e6ace14a271e6418 Cr-Commit-Position: refs/heads/master@{#404300}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fixed patch set 1 errors. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M ui/login/account_picker/user_pod_row.css View 1 chunk +1 line, -2 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ui/login/screen_container.css View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
sammiequon
jdufault@, xiyuan@ - Please take a look.
4 years, 5 months ago (2016-07-07 19:54:06 UTC) #3
xiyuan
lgtm but please wait for jdufault https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/user_pod_row.js File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/user_pod_row.js#newcode1142 ui/login/account_picker/user_pod_row.js:1142: visible ? this.pinKeyboard.focus() ...
4 years, 5 months ago (2016-07-07 20:01:41 UTC) #4
jdufault
lgtm after comment https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/user_pod_row.js File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/user_pod_row.js#newcode1142 ui/login/account_picker/user_pod_row.js:1142: visible ? this.pinKeyboard.focus() : this.passwordElement.focus(); On ...
4 years, 5 months ago (2016-07-07 20:46:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132753002/20001
4 years, 5 months ago (2016-07-07 21:24:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-07 23:26:37 UTC) #10
sammiequon
https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/user_pod_row.js File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2132753002/diff/1/ui/login/account_picker/user_pod_row.js#newcode1142 ui/login/account_picker/user_pod_row.js:1142: visible ? this.pinKeyboard.focus() : this.passwordElement.focus(); On 2016/07/07 20:01:40, xiyuan ...
4 years, 5 months ago (2016-07-08 00:21:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132753002/40001
4 years, 5 months ago (2016-07-08 00:21:59 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-08 01:23:32 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 01:23:42 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 01:27:08 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4c8533dd7c1b9ac29add8014e6ace14a271e6418
Cr-Commit-Position: refs/heads/master@{#404300}

Powered by Google App Engine
This is Rietveld 408576698