Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: content/public/test/test_navigation_observer.cc

Issue 2132673002: Adding Navigation Throttles to DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Got browser test to work with IsolateAllSitesForTesting Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_browser.gypi ('k') | content/test/data/devtools/control_navigations/iframe_navigation.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/test_navigation_observer.cc
diff --git a/content/public/test/test_navigation_observer.cc b/content/public/test/test_navigation_observer.cc
index 1371ba32a937ae3d648d93ccc01c780c9ffddbd6..df579dc7e6ba7af4baa64fee4603135c2143df9e 100644
--- a/content/public/test/test_navigation_observer.cc
+++ b/content/public/test/test_navigation_observer.cc
@@ -47,6 +47,14 @@ class TestNavigationObserver::TestWebContentsObserver
parent_->OnDidStopLoading(web_contents());
}
+ void DidFailLoad(RenderFrameHost* render_frame_host,
+ const GURL& validated_url,
+ int error_code,
+ const base::string16& error_description,
+ bool was_ignored_by_handler) override {
+ fprintf(stderr, "YARR! %s\n", validated_url.spec().c_str());
nasko 2016/07/15 14:42:31 You plan to remove this before commit, right?
alex clarke (OOO till 29th) 2016/07/15 17:12:12 Done.
+ }
+
void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host,
const GURL& validated_url,
bool is_error_page,
« no previous file with comments | « content/content_browser.gypi ('k') | content/test/data/devtools/control_navigations/iframe_navigation.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698