Adding Navigation Throttles to DevTools

content/browser/devtools/page_navigation_throttle.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/devtools/page_navigation_throttle.h"
+
+#include "base/strings/stringprintf.h"
+#include "content/browser/devtools/protocol/page_handler.h"
+#include "content/public/browser/navigation_handle.h"
+#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/web_contents.h"
+
+namespace content {
+namespace devtools {
+
+PageNavigationThrottle::PageNavigationThrottle(
+    base::WeakPtr<page::PageHandler> page_handler,
+    int navigation_id,
+    content::NavigationHandle* navigation_handle)
+    : content::NavigationThrottle(navigation_handle),
+      navigation_id_(navigation_id),
+      page_handler_(page_handler) {}
+
+PageNavigationThrottle::~PageNavigationThrottle() {
+  if (page_handler_)
+    page_handler_->OnPageNavigationThrottleDisposed(navigation_id_);
+}
+
+NavigationThrottle::ThrottleCheckResult
+PageNavigationThrottle::WillStartRequest() {
+  if (!page_handler_)
+    return ThrottleCheckResult::PROCEED;
+  page_handler_->ShouldAllowNavigation(this);
+  return ThrottleCheckResult::DEFER;
+}
+
+NavigationThrottle::ThrottleCheckResult
+PageNavigationThrottle::WillRedirectRequest() {
+  if (!page_handler_)
+    return ThrottleCheckResult::PROCEED;
+  page_handler_->ShouldAllowRedirect(this);
+  return ThrottleCheckResult::DEFER;
+}
+
+NavigationThrottle::ThrottleCheckResult
+PageNavigationThrottle::WillProcessResponse() {
+  return ThrottleCheckResult::PROCEED;
+}
+
+std::string PageNavigationThrottle::GetFrameId() const {
+  WebContents* web_contents = navigation_handle()->GetWebContents();
+  // NOTE keep in sync with BlinkPlatformImpl::getUniqueIdForProcess.
+  return base::StringPrintf(
+      "%d.%d",
+      base::GetProcId(web_contents->GetRenderProcessHost()->GetHandle()),
+      navigation_handle()->GetFrameTreeNodeId());

[pfeldman, 2016/07/07 17:26:18]

The rest of the code uses IdentifiersFactory::frameId (which is not as good as
yours), but unfortunately we don't have cross-cutting id system for frames in
chrome yet.

[alex clarke (OOO till 29th), 2016/07/08 10:37:57]

FWIW I'm under the impression this gives the same result as
IdentifiersFactory::frameId.
What should we do here? I had hoped for interoperability of frame identifiers :)

[pfeldman, 2016/07/08 15:33:14]

Are you still under that impression, even after my comment? :-)

Fixing this is hard and Sami has the background for this. Do you absolutely need
to pass frame ids at this point?

[alex clarke (OOO till 29th), 2016/07/08 17:15:40]

Looking at some of the use cases we had in mind we can get away with knowing if
the main frame was navigating or if it was a child frame.  So I've gone ahead
and removed this and added a couple of booleans to the events.

+}
+
+}  // namespace devtools
+}  // namespace content