 Chromium Code Reviews
 Chromium Code Reviews Issue 2132663002:
  kiosk: Add status report for os update and running app  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 2132663002:
  kiosk: Add status report for os update and running app  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: components/policy/proto/device_management_backend.proto | 
| diff --git a/components/policy/proto/device_management_backend.proto b/components/policy/proto/device_management_backend.proto | 
| index bbdc25ee30a9c4c00f12dbefef543d6c0cfdd878..fc4a6e679e927bc6bf2a551e9f71a48d91268b72 100644 | 
| --- a/components/policy/proto/device_management_backend.proto | 
| +++ b/components/policy/proto/device_management_backend.proto | 
| @@ -377,16 +377,16 @@ message PolicyData { | 
| // The unique directory api ID of the device which was generated on the | 
| // server-side. | 
| optional string directory_api_id = 22; | 
| - | 
| + | 
| // List of device affiliation IDs. If exists overlap between user | 
| // affiliation IDs and device affiliation IDs, we consider that the user is | 
| // affiliated on the device. Otherwise the user is not affiliated on the | 
| - // device. Should be fetched with device policy. Ignored if fetched with | 
| + // device. Should be fetched with device policy. Ignored if fetched with | 
| // other polices. | 
| repeated string device_affiliation_ids = 23; | 
| - | 
| + | 
| // List of user affiliation IDs. The list is used to define if current user | 
| - // is affiliated on the device. See device_affiliation_ids for details. | 
| + // is affiliated on the device. See device_affiliation_ids for details. | 
| // Should be fetched with user policy. Ignored if fetched with other polices. | 
| repeated string user_affiliation_ids = 24; | 
| } | 
| @@ -745,6 +745,30 @@ message DeviceStatusReportRequest { | 
| // CPU temp information. | 
| repeated CPUTempInfo cpu_temp_info = 16; | 
| + | 
| + // This field is set, only when an OS update is needed because of Kiosk | 
| + // app pinned OS version of an updated Kiosk app is different from the | 
| + // current OS version. | 
| + optional OsUpdateStatus os_update_status = 17; | 
| + | 
| + // Set only when there is a currently running Kiosk app. | 
| + // If no kiosk app is currently running, then this field is empty. | 
| 
jinzhang1
2016/07/07 17:46:42
Let's change this comment to:
// Set only when the
 
xiyuan
2016/07/07 17:53:59
I updated with the following:
  // Set only when t
 
jinzhang1
2016/07/07 17:59:31
LGTM. Did you forget to update the CL?
 
jinzhang1
2016/07/07 18:00:15
never mind. saw the new patch. lgtm.
 | 
| + optional AppStatus running_kiosk_app = 18; | 
| +} | 
| + | 
| +message OsUpdateStatus { | 
| + enum UpdateStatus { | 
| + OS_UP_TO_DATE = 0; | 
| + OS_IMAGE_DOWNLOAD_NOT_STARTED = 1; | 
| + OS_IMAGE_DOWNLOAD_IN_PROGRESS = 2; | 
| + OS_UPDATE_NEED_REBOOT = 3; | 
| + } | 
| + | 
| + optional UpdateStatus update_status = 1; | 
| + optional string new_platform_version = 2; | 
| + | 
| + // New required platform version from the pending updated Kiosk app. | 
| + optional string new_required_platform_version = 3; | 
| } | 
| // Provides status information for an installed app/extension. | 
| @@ -760,6 +784,9 @@ message AppStatus { | 
| // If true, the application is currently in a self-reported error state. | 
| optional bool error = 4; | 
| + | 
| + // App required Chrome version, specified in app’s manifest file. | 
| + optional string required_platform_version = 5; | 
| } | 
| // Report session (a user on one device) level status. |