chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc - Issue 2132633002: Tracking composition range on the browser side (Aura)

Unified Diff: chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

Issue 2132633002: Tracking composition range on the browser side (Aura) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatting Fixes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/frame_host/render_widget_host_view_child_frame.h » ('j') | content/browser/renderer_host/render_widget_host_view_aura_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

diff --git a/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc b/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

index 47eca0fa291d09583e9f4e61a666c18900533d03..63a1a60bcefb1e313bd7066cf4b3fccac736da8a 100644

--- a/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

+++ b/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

@@ -515,6 +515,11 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,

send_tab_insert_text_wait_for_bounds_change(view);

}

+// TODO(ekaramad): Add a test here to show that the composition range is being

+// tracked for all of the child frames.Composition range update could occur in

Charlie Reis 2016/07/08 18:55:24 nit: Missing space between sentences.

EhsanK 2016/07/11 18:07:21 Acknowledged.

+// response to WebWidget::setComposition. Write a test when that method is

+// implemented for WebFrameWidgetImpl (crbug.com/602723).

Charlie Reis 2016/07/08 18:55:24 This comment would be clearer if you started with

EhsanK 2016/07/11 18:07:21 Fair enough. After giving it some more thought, I

Charlie Reis 2016/07/11 23:56:19 Acknowledged.

// TODO(ekaramad): The following tests are specifically written for Aura and are

// based on InputMethodObserver. Write similar tests for Mac/Android/Mus

// (crbug.com/602723).