Tracking composition range on the browser side (Aura)

chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/command_line.h"
+#include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 #include "content/public/test/text_input_test_utils.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
+#include "ui/base/ime/composition_underline.h"
 #include "ui/base/ime/text_input_client.h"
 #include "ui/base/ime/text_input_mode.h"
 #include "ui/base/ime/text_input_type.h"
 #include "url/gurl.h"
 
 // TODO(ekaramad): The following tests are only active on aura platforms. After
 // fixing crbug.com/578168 for all platforms, the following tests should be
 // activated for other platforms, e.g., Mac and Android (crbug.com/602723).
 
 ///////////////////////////////////////////////////////////////////////////////
@@ skipping 168 matching lines @@
   void VerifyChange() {
     if (expected_view_ == tester()->GetUpdatedView())
       OnSuccess();
   }
 
   const content::RenderWidgetHostView* const expected_view_;
 
   DISALLOW_COPY_AND_ASSIGN(ViewSelectionBoundsChangedObserver);
 };
 
+// This class observes the |expected_view| for the first change in its
+// composition range information.
+class ViewCompositionRangeChangedObserver
+    : public TextInputManagerObserverBase {
+ public:
+  ViewCompositionRangeChangedObserver(
+      content::WebContents* web_contents,
+      content::RenderWidgetHostView* expected_view)
+      : TextInputManagerObserverBase(web_contents),
+        expected_view_(expected_view) {
+    tester()->SetOnImeCompositionRangeChangedCallback(
+        base::Bind(&ViewCompositionRangeChangedObserver::VerifyChange,
+                   base::Unretained(this)));
+  }
+
+ private:
+  void VerifyChange() {
+    if (expected_view_ == tester()->GetUpdatedView())
+      OnSuccess();
+  }
+
+  const content::RenderWidgetHostView* const expected_view_;
+
+  DISALLOW_COPY_AND_ASSIGN(ViewCompositionRangeChangedObserver);
+};
+
 }  // namespace
 
 // Main class for all TextInputState and IME related tests.
 class SitePerProcessTextInputManagerTest : public InProcessBrowserTest {
  public:
   SitePerProcessTextInputManagerTest() {}
   ~SitePerProcessTextInputManagerTest() override {}
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     content::IsolateAllSitesForTesting(command_line);
@@ skipping 258 matching lines @@
   reset_state_observer.Wait();
 }
 
 // This test creates a page with multiple child frames and adds an <input> to
 // each frame. Then, sequentially, each <input> is focused by sending a tab key.
 // Then, after |TextInputState.type| for a view is changed to text, another key
 // is pressed (a character) and then the test verifies that TextInputManager
 // receives the corresponding update on the change in selection bounds on the
 // browser side.
 IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
-                       TrackSelectionBoundsForChildFrames) {
+                       TrackSelectionBoundsForAllFrames) {
   CreateIframePage("a(b,c(a,b),d)");
   std::vector<content::RenderFrameHost*> frames{
       GetFrame(IndexVector{}),     GetFrame(IndexVector{0}),
       GetFrame(IndexVector{1}),    GetFrame(IndexVector{1, 0}),
       GetFrame(IndexVector{1, 1}), GetFrame(IndexVector{2})};
   std::vector<content::RenderWidgetHostView*> views;
   for (auto frame : frames)
     views.push_back(frame->GetView());
   for (size_t i = 0; i < frames.size(); ++i)
     AddInputFieldToFrame(frames[i], "text", "", true);
@@ skipping 10 matching lines @@
     ViewSelectionBoundsChangedObserver bounds_observer(web_contents, view);
     SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('E'),
                      ui::DomCode::US_E, ui::VKEY_E, false, false, false, false);
     bounds_observer.Wait();
   };
 
   for (auto view : views)
     send_tab_insert_text_wait_for_bounds_change(view);
 }
 
+// This test creates a page with multiple child frames and adds an <input> to
+// each frame. Then, sequentially, each <input> is focused by sending a tab key.
+// Then, after |TextInputState.type| for a view is changed to text, the test
+// sends a set composition IPC to the active widget and waits until the widget
+// updates its composition range.
+IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
+                       TrackCompositionRangeForAllFrames) {
+  // TODO(ekaramd): After IME methods are implemented for WebFrameWidgetImpl,
+  // change the page so that it contains child frames as well
+  // (crbug.com/626746).
+  CreateIframePage("a()");
+  std::vector<content::RenderFrameHost*> frames{GetFrame(IndexVector{})};
+  std::vector<content::RenderWidgetHostView*> views;
+  for (auto frame : frames)
+    views.push_back(frame->GetView());
+  for (size_t i = 0; i < frames.size(); ++i)
+    AddInputFieldToFrame(frames[i], "text", "", true);
+
+  content::WebContents* web_contents = active_contents();
+
+  ui::CompositionText composition;
+  composition.text = base::ASCIIToUTF16("text");
+  composition.underlines = {ui::CompositionUnderline()};
+  composition.selection = gfx::Range();
+  auto send_tab_set_composition_wait_for_bounds_change =
+      [&web_contents, &composition](content::RenderWidgetHostView* view) {
+        ViewTextInputTypeObserver type_observer(web_contents, view,
+                                                ui::TEXT_INPUT_TYPE_TEXT);
+        SimulateKeyPress(web_contents, ui::DomKey::TAB, ui::DomCode::TAB,
+                         ui::VKEY_TAB, false, false, false, false);
+        type_observer.Wait();
+        ViewCompositionRangeChangedObserver range_observer(web_contents, view);
+        content::SetCompositionTextForFocusedTextInputClient(web_contents,
+                                                             composition);
+        range_observer.Wait();
+      };
+
+  for (auto view : views)
+    send_tab_set_composition_wait_for_bounds_change(view);
+}
+
 // TODO(ekaramad): The following tests are specifically written for Aura and are
 // based on InputMethodObserver. Write similar tests for Mac/Android/Mus
 // (crbug.com/602723).
 
 // Observes current input method for state changes.
 class InputMethodObserverBase {
  public:
   explicit InputMethodObserverBase(content::WebContents* web_contents)
       : success_(false),
         test_observer_(content::TestInputMethodObserver::Create(web_contents)) {
@@ skipping 89 matching lines @@
   EXPECT_FALSE(send_and_check_show_ime());
 
   // Set |TextInputState.show_ime_if_needed|. Expect IME.
   sender.SetShowImeIfNeeded(true);
   EXPECT_TRUE(send_and_check_show_ime());
 
   // Set |TextInputState.type| to ui::TEXT_INPUT_TYPE_NONE. Expect no IME.
   sender.SetType(ui::TEXT_INPUT_TYPE_NONE);
   EXPECT_FALSE(send_and_check_show_ime());
 }