Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 2132633002: Tracking composition range on the browser side (Aura) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatting Fixes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_widget_host_view_child_frame.h" 5 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 RenderWidgetHostView* parent_host_view, 226 RenderWidgetHostView* parent_host_view,
227 const gfx::Rect& bounds) { 227 const gfx::Rect& bounds) {
228 NOTREACHED(); 228 NOTREACHED();
229 } 229 }
230 230
231 void RenderWidgetHostViewChildFrame::InitAsFullscreen( 231 void RenderWidgetHostViewChildFrame::InitAsFullscreen(
232 RenderWidgetHostView* reference_host_view) { 232 RenderWidgetHostView* reference_host_view) {
233 NOTREACHED(); 233 NOTREACHED();
234 } 234 }
235 235
236 void RenderWidgetHostViewChildFrame::ImeCompositionRangeChanged(
237 const gfx::Range& range,
238 const std::vector<gfx::Rect>& character_bounds) {
239 // TODO(kenrb): Fix OOPIF Ime.
240 }
241
242 void RenderWidgetHostViewChildFrame::UpdateCursor(const WebCursor& cursor) { 236 void RenderWidgetHostViewChildFrame::UpdateCursor(const WebCursor& cursor) {
243 if (frame_connector_) 237 if (frame_connector_)
244 frame_connector_->UpdateCursor(cursor); 238 frame_connector_->UpdateCursor(cursor);
245 } 239 }
246 240
247 void RenderWidgetHostViewChildFrame::SetIsLoading(bool is_loading) { 241 void RenderWidgetHostViewChildFrame::SetIsLoading(bool is_loading) {
248 // It is valid for an inner WebContents's SetIsLoading() to end up here. 242 // It is valid for an inner WebContents's SetIsLoading() to end up here.
249 // This is because an inner WebContents's main frame's RenderWidgetHostView 243 // This is because an inner WebContents's main frame's RenderWidgetHostView
250 // is a RenderWidgetHostViewChildFrame. In contrast, when there is no 244 // is a RenderWidgetHostViewChildFrame. In contrast, when there is no
251 // inner/outer WebContents, only subframe's RenderWidgetHostView can be a 245 // inner/outer WebContents, only subframe's RenderWidgetHostView can be a
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
684 678
685 bool RenderWidgetHostViewChildFrame::IsChildFrameForTesting() const { 679 bool RenderWidgetHostViewChildFrame::IsChildFrameForTesting() const {
686 return true; 680 return true;
687 } 681 }
688 682
689 cc::SurfaceId RenderWidgetHostViewChildFrame::SurfaceIdForTesting() const { 683 cc::SurfaceId RenderWidgetHostViewChildFrame::SurfaceIdForTesting() const {
690 return surface_id_; 684 return surface_id_;
691 }; 685 };
692 686
693 } // namespace content 687 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698