Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 213263004: Made IndexedDB's comparators public. (Closed)

Created:
6 years, 8 months ago by cmumford
Modified:
6 years, 8 months ago
Reviewers:
dgrogan
CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Made IndexedDB's comparators public. Moved IndexedDBBackingStore::Comparator and LevelDBDatabase::ComparatorAdapter up into their respective class definitions. This allows them to be instantiated (or derived from). This change is necessary in order to facilitate the authoring of an IndexedDB diagnostic utility application. The design of LevelDB is such that the same comparator must be used when opening a LevelDB that was used to create it. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -27 lines) Patch
M content/browser/indexed_db/indexed_db_backing_store.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M content/browser/indexed_db/leveldb/leveldb_database.h View 2 chunks +19 lines, -0 lines 0 comments Download
M content/browser/indexed_db/leveldb/leveldb_database.cc View 2 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
cmumford
No implementation changes, only making two classes public.
6 years, 8 months ago (2014-03-26 18:53:21 UTC) #1
dgrogan
lgtm
6 years, 8 months ago (2014-03-26 19:34:02 UTC) #2
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 8 months ago (2014-03-26 21:32:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/213263004/1
6 years, 8 months ago (2014-03-26 21:33:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 03:53:03 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-27 03:53:04 UTC) #6
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 8 months ago (2014-03-27 15:28:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/213263004/1
6 years, 8 months ago (2014-03-27 15:28:16 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-03-27 15:30:10 UTC) #9
Message was sent while issue was closed.
Change committed as 259867

Powered by Google App Engine
This is Rietveld 408576698