content/browser/web_contents/web_contents_impl_browsertest.cc - Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_browsertest.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nasko@ nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl_browsertest.cc

diff --git a/content/browser/web_contents/web_contents_impl_browsertest.cc b/content/browser/web_contents/web_contents_impl_browsertest.cc

index 5c82189e422089a92737cad970d4f144fba51f7c..d1f781f96b3ebaa621da0f5a7bb181137c7524a0 100644

--- a/content/browser/web_contents/web_contents_impl_browsertest.cc

+++ b/content/browser/web_contents/web_contents_impl_browsertest.cc

@@ -922,7 +922,7 @@ IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest,

TestNavigationManager cross_site_delayer(shell()->web_contents(),

kCrossSiteURL);

shell()->LoadURL(kCrossSiteURL);

- cross_site_delayer.WaitForWillStartRequest();

+ EXPECT_TRUE(cross_site_delayer.WaitForWillStartRequest());

// Click on a link in the page. This will show the BeforeUnload dialog.

// Ensure the dialog is not dismissed, which will cause it to still be

« no previous file with comments | « content/browser/frame_host/navigation_handle_impl_browsertest.cc ('k') | content/public/test/browser_test_utils.h » ('j') | no next file with comments »