Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.h

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nasko@ nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.h b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
index 7e2087c57e1f099cf6c580b630989e55cf9509b6..f8268d7da7085dde93e84f820405857340a6e9e6 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
@@ -42,10 +42,6 @@ enum UserAbortType {
// without committing, either without error or with net::ERR_ABORTED.
ABORT_OTHER,
- // The load aborted due to another navigation, but it isn't clear what type of
- // navigation it was.
- ABORT_UNKNOWN_NAVIGATION,
-
// Add values before this final count.
ABORT_LAST_ENTRY
};
@@ -93,6 +89,7 @@ struct PageLoadExtraInfo {
// The abort time and time to abort for this page load. If the page was not
// aborted, |abort_type| will be |ABORT_NONE|.
const UserAbortType abort_type;
+
const base::Optional<base::TimeDelta> time_to_abort;
// Extra information supplied to the page load metrics system from the
« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698