Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nasko@ nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
index 2c14f944c1617f24043e3b96b2f3b55cc47c8755..97289454be8014db5a47aaa02e754ad8ebd98c25 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
@@ -443,14 +443,14 @@ TEST_F(FromGWSPageLoadMetricsObserverTest,
}
}
-TEST_F(FromGWSPageLoadMetricsObserverTest, UnknownNavigationBeforeCommit) {
+TEST_F(FromGWSPageLoadMetricsObserverTest, NewNavigationBeforeCommit) {
NavigateAndCommit(GURL(kGoogleSearchResultsUrl));
StartNavigation(GURL("http://example.test"));
// Simulate the user performing another navigation before commit.
- StartNavigation(GURL("https://www.example.com"));
+ NavigateAndCommit(GURL("https://www.example.com"));
histogram_tester().ExpectTotalCount(
- internal::kHistogramFromGWSAbortUnknownNavigationBeforeCommit, 1);
+ internal::kHistogramFromGWSAbortNewNavigationBeforeCommit, 1);
}
TEST_F(FromGWSPageLoadMetricsObserverTest, NewNavigationBeforePaint) {

Powered by Google App Engine
This is Rietveld 408576698