Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: components/page_load_metrics/browser/page_load_metrics_observer.h

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Attach the throttle first so it gets all notifications before any DEFERs Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/page_load_metrics_observer.h
diff --git a/components/page_load_metrics/browser/page_load_metrics_observer.h b/components/page_load_metrics/browser/page_load_metrics_observer.h
index ffc494793ca1dd4551b80734cfbd65665f393881..9e7a0f4b09faa977eaeec50c295bce6b8dd263f6 100644
--- a/components/page_load_metrics/browser/page_load_metrics_observer.h
+++ b/components/page_load_metrics/browser/page_load_metrics_observer.h
@@ -42,10 +42,6 @@ enum UserAbortType {
// without committing, either without error or with net::ERR_ABORTED.
ABORT_OTHER,
- // The load aborted due to another navigation, but it isn't clear what type of
- // navigation it was.
- ABORT_UNKNOWN_NAVIGATION,
-
// Add values before this final count.
ABORT_LAST_ENTRY
};
@@ -93,6 +89,7 @@ struct PageLoadExtraInfo {
// The abort time and time to abort for this page load. If the page was not
// aborted, |abort_type| will be |ABORT_NONE|.
const UserAbortType abort_type;
+
const base::Optional<base::TimeDelta> time_to_abort;
// Extra information supplied to the page load metrics system from the

Powered by Google App Engine
This is Rietveld 408576698