chrome/browser/chrome_content_browser_client.cc - Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a NavigationThrottle to help track provisional abort metrics Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h » ('j') | components/page_load_metrics/browser/metrics_web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 78e601432069b9cb0c19ba47216fd86ee9d06825..9ebbf23a7ca52740163a0c4f0793b5c53ced4391 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -125,6 +125,7 @@

#include "components/google/core/browser/google_util.h"

#include "components/metrics/client_info.h"

#include "components/net_log/chrome_net_log.h"

+#include "components/page_load_metrics/browser/metrics_navigation_throttle.h"

#include "components/pref_registry/pref_registry_syncable.h"

#include "components/prefs/pref_service.h"

#include "components/prefs/scoped_user_pref_update.h"

@@ -2978,6 +2979,11 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(

throttles.push_back(new extensions::ExtensionNavigationThrottle(handle));

#endif

+ if (handle->IsInMainFrame()) {

+ throttles.push_back(

+ page_load_metrics::MetricsNavigationThrottle::Create(handle));

+ }

return throttles;

}