Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nasko@ nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OB SERVER_H_ 5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OB SERVER_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OB SERVER_H_ 6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OB SERVER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/optional.h" 9 #include "base/optional.h"
10 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h" 10 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
11 #include "url/gurl.h" 11 #include "url/gurl.h"
12 12
13 namespace internal { 13 namespace internal {
14 // Exposed for tests. 14 // Exposed for tests.
15 extern const char kHistogramFromGWSDomContentLoaded[]; 15 extern const char kHistogramFromGWSDomContentLoaded[];
16 extern const char kHistogramFromGWSLoad[]; 16 extern const char kHistogramFromGWSLoad[];
17 extern const char kHistogramFromGWSFirstPaint[]; 17 extern const char kHistogramFromGWSFirstPaint[];
18 extern const char kHistogramFromGWSFirstTextPaint[]; 18 extern const char kHistogramFromGWSFirstTextPaint[];
19 extern const char kHistogramFromGWSFirstImagePaint[]; 19 extern const char kHistogramFromGWSFirstImagePaint[];
20 extern const char kHistogramFromGWSFirstContentfulPaint[]; 20 extern const char kHistogramFromGWSFirstContentfulPaint[];
21 extern const char kHistogramFromGWSParseStartToFirstContentfulPaint[]; 21 extern const char kHistogramFromGWSParseStartToFirstContentfulPaint[];
22 extern const char kHistogramFromGWSParseDuration[]; 22 extern const char kHistogramFromGWSParseDuration[];
23 extern const char kHistogramFromGWSParseStart[]; 23 extern const char kHistogramFromGWSParseStart[];
24 extern const char kHistogramFromGWSAbortStopBeforePaint[]; 24 extern const char kHistogramFromGWSAbortStopBeforePaint[];
25 extern const char kHistogramFromGWSAbortStopBeforeInteraction[]; 25 extern const char kHistogramFromGWSAbortStopBeforeInteraction[];
26 extern const char kHistogramFromGWSAbortStopBeforeCommit[]; 26 extern const char kHistogramFromGWSAbortStopBeforeCommit[];
27 extern const char kHistogramFromGWSAbortCloseBeforePaint[]; 27 extern const char kHistogramFromGWSAbortCloseBeforePaint[];
28 extern const char kHistogramFromGWSAbortCloseBeforeInteraction[]; 28 extern const char kHistogramFromGWSAbortCloseBeforeInteraction[];
29 extern const char kHistogramFromGWSAbortCloseBeforeCommit[]; 29 extern const char kHistogramFromGWSAbortCloseBeforeCommit[];
30 extern const char kHistogramFromGWSAbortNewNavigationBeforeCommit[];
30 extern const char kHistogramFromGWSAbortNewNavigationBeforePaint[]; 31 extern const char kHistogramFromGWSAbortNewNavigationBeforePaint[];
31 extern const char kHistogramFromGWSAbortNewNavigationBeforeInteraction[]; 32 extern const char kHistogramFromGWSAbortNewNavigationBeforeInteraction[];
32 extern const char kHistogramFromGWSAbortReloadBeforeInteraction[]; 33 extern const char kHistogramFromGWSAbortReloadBeforeInteraction[];
33 extern const char kHistogramFromGWSAbortUnknownNavigationBeforeCommit[];
34 34
35 } // namespace internal 35 } // namespace internal
36 36
37 // FromGWSPageLoadMetricsLogger is a peer class to 37 // FromGWSPageLoadMetricsLogger is a peer class to
38 // FromGWSPageLoadMetricsObserver. FromGWSPageLoadMetricsLogger is responsible 38 // FromGWSPageLoadMetricsObserver. FromGWSPageLoadMetricsLogger is responsible
39 // for tracking state needed to decide if metrics should be logged, and to log 39 // for tracking state needed to decide if metrics should be logged, and to log
40 // metrics in cases where metrics should be logged. FromGWSPageLoadMetricsLogger 40 // metrics in cases where metrics should be logged. FromGWSPageLoadMetricsLogger
41 // exists to decouple the logging policy implementation from other Chromium 41 // exists to decouple the logging policy implementation from other Chromium
42 // classes such as NavigationHandle and related infrastructure, in order to make 42 // classes such as NavigationHandle and related infrastructure, in order to make
43 // the code more unit testable. 43 // the code more unit testable.
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 178
179 void OnUserInput(const blink::WebInputEvent& event) override; 179 void OnUserInput(const blink::WebInputEvent& event) override;
180 180
181 private: 181 private:
182 FromGWSPageLoadMetricsLogger logger_; 182 FromGWSPageLoadMetricsLogger logger_;
183 183
184 DISALLOW_COPY_AND_ASSIGN(FromGWSPageLoadMetricsObserver); 184 DISALLOW_COPY_AND_ASSIGN(FromGWSPageLoadMetricsObserver);
185 }; 185 };
186 186
187 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS _OBSERVER_H_ 187 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS _OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698