[page_load_metrics] Add a NavigationThrottle for richer abort metrics

chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h"
 #include <string>
 
 #include "base/metrics/histogram.h"
 #include "base/strings/string_util.h"
 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
@@ skipping 20 matching lines @@
     "PageLoad.Clients.FromGoogleSearch.PaintTiming."
     "NavigationToFirstContentfulPaint";
 const char kHistogramFromGWSParseStartToFirstContentfulPaint[] =
     "PageLoad.Clients.FromGoogleSearch.PaintTiming."
     "ParseStartToFirstContentfulPaint";
 const char kHistogramFromGWSParseDuration[] =
     "PageLoad.Clients.FromGoogleSearch.ParseTiming.ParseDuration";
 const char kHistogramFromGWSParseStart[] =
     "PageLoad.Clients.FromGoogleSearch.ParseTiming.NavigationToParseStart";
 
-const char kHistogramFromGWSAbortUnknownNavigationBeforeCommit[] =
-    "PageLoad.Clients.FromGoogleSearch.AbortTiming.UnknownNavigation."
-    "BeforeCommit";
+const char kHistogramFromGWSAbortNewNavigationBeforeCommit[] =
+    "PageLoad.Clients.FromGoogleSearch.AbortTiming.NewNavigation.BeforeCommit";
 const char kHistogramFromGWSAbortNewNavigationBeforePaint[] =
     "PageLoad.Clients.FromGoogleSearch.AbortTiming.NewNavigation.AfterCommit."
     "BeforePaint";
 const char kHistogramFromGWSAbortNewNavigationBeforeInteraction[] =
     "PageLoad.Clients.FromGoogleSearch.AbortTiming.NewNavigation.AfterPaint."
     "BeforeInteraction";
 const char kHistogramFromGWSAbortStopBeforeCommit[] =
     "PageLoad.Clients.FromGoogleSearch.AbortTiming.Stop.BeforeCommit";
 const char kHistogramFromGWSAbortStopBeforePaint[] =
     "PageLoad.Clients.FromGoogleSearch.AbortTiming.Stop.AfterCommit."
     "BeforePaint";
 const char kHistogramFromGWSAbortStopBeforeInteraction[] =
     "PageLoad.Clients.FromGoogleSearch.AbortTiming.Stop.AfterPaint."
     "BeforeInteraction";
 const char kHistogramFromGWSAbortCloseBeforeCommit[] =
     "PageLoad.Clients.FromGoogleSearch.AbortTiming.Close.BeforeCommit";
 const char kHistogramFromGWSAbortCloseBeforePaint[] =
     "PageLoad.Clients.FromGoogleSearch.AbortTiming.Close.AfterCommit."
     "BeforePaint";
 const char kHistogramFromGWSAbortCloseBeforeInteraction[] =
     "PageLoad.Clients.FromGoogleSearch.AbortTiming.Close.AfterPaint."
     "BeforeInteraction";
 const char kHistogramFromGWSAbortOtherBeforeCommit[] =
     "PageLoad.Clients.FromGoogleSearch.AbortTiming.Other.BeforeCommit";
+const char kHistogramFromGWSAbortReloadBeforeCommit[] =
+    "PageLoad.Clients.FromGoogleSearch.AbortTiming.Reload.BeforeCommit";
 const char kHistogramFromGWSAbortReloadBeforePaint[] =
     "PageLoad.Clients.FromGoogleSearch.AbortTiming.Reload.AfterCommit."
     "BeforePaint";
 const char kHistogramFromGWSAbortReloadBeforeInteraction[] =
     "PageLoad.Clients.FromGoogleSearch.AbortTiming.Reload.AfterPaint."
     "Before1sDelayedInteraction";
+const char kHistogramFromGWSAbortForwardBackBeforeCommit[] =
+    "PageLoad.Clients.FromGoogleSearch.AbortTiming.ForwardBackNavigation."
+    "BeforeCommit";
 const char kHistogramFromGWSAbortForwardBackBeforePaint[] =
     "PageLoad.Clients.FromGoogleSearch.AbortTiming.ForwardBackNavigation."
     "AfterCommit.BeforePaint";
 const char kHistogramFromGWSAbortForwardBackBeforeInteraction[] =
     "PageLoad.Clients.FromGoogleSearch.AbortTiming.ForwardBackNavigation."
     "AfterPaint.Before1sDelayedInteraction";
 
 }  // namespace internal
 
 namespace {
@@ skipping 19 matching lines @@
                           time_to_abort);
       break;
     case UserAbortType::ABORT_FORWARD_BACK:
       PAGE_LOAD_HISTOGRAM(
           internal::kHistogramFromGWSAbortForwardBackBeforePaint,
           time_to_abort);
       break;
     default:
       // These should only be logged for provisional aborts.
       DCHECK_NE(abort_type, UserAbortType::ABORT_OTHER);
-      DCHECK_NE(abort_type, UserAbortType::ABORT_UNKNOWN_NAVIGATION);
       break;
   }
 }
 
 void LogAbortsAfterPaintBeforeInteraction(UserAbortType abort_type,
                                           base::TimeDelta time_to_abort) {
   switch (abort_type) {
     case UserAbortType::ABORT_STOP:
       PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSAbortStopBeforeInteraction,
                           time_to_abort);
@@ skipping 14 matching lines @@
           time_to_abort);
       break;
     case UserAbortType::ABORT_FORWARD_BACK:
       PAGE_LOAD_HISTOGRAM(
           internal::kHistogramFromGWSAbortForwardBackBeforeInteraction,
           time_to_abort);
       break;
     default:
       // These should only be logged for provisional aborts.
       DCHECK_NE(abort_type, UserAbortType::ABORT_OTHER);
-      DCHECK_NE(abort_type, UserAbortType::ABORT_UNKNOWN_NAVIGATION);
       break;
   }
 }
 
 void LogProvisionalAborts(UserAbortType abort_type,
                           base::TimeDelta time_to_abort) {
   switch (abort_type) {
     case UserAbortType::ABORT_STOP:
       PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSAbortStopBeforeCommit,
                           time_to_abort);
       break;
     case UserAbortType::ABORT_CLOSE:
       PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSAbortCloseBeforeCommit,
                           time_to_abort);
       break;
-    case UserAbortType::ABORT_UNKNOWN_NAVIGATION:
-      PAGE_LOAD_HISTOGRAM(
-          internal::kHistogramFromGWSAbortUnknownNavigationBeforeCommit,
-          time_to_abort);
-      break;
     case UserAbortType::ABORT_OTHER:
       PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSAbortOtherBeforeCommit,
                           time_to_abort);
       break;
+    case UserAbortType::ABORT_NEW_NAVIGATION:
+      PAGE_LOAD_HISTOGRAM(
+          internal::kHistogramFromGWSAbortNewNavigationBeforeCommit,
+          time_to_abort);
+      break;
+    case UserAbortType::ABORT_RELOAD:
+      PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSAbortReloadBeforeCommit,
+                          time_to_abort);
+      break;
+    case UserAbortType::ABORT_FORWARD_BACK:
+      PAGE_LOAD_HISTOGRAM(
+          internal::kHistogramFromGWSAbortForwardBackBeforeCommit,
+          time_to_abort);
+      break;
     default:
-      // There are other abort types that could be logged, but they occur in
-      // very small amounts that it isn't worth logging.
-      // TODO(csharrison): Once transitions can be acquired before commit, log
-      // the Reload/NewNavigation/ForwardBack variants here.
+      NOTREACHED();
       break;
   }
 }
 
 bool WasAbortedInForeground(
     UserAbortType abort_type,
     const base::Optional<base::TimeDelta>& time_to_abort,
     const page_load_metrics::PageLoadExtraInfo& info) {
   if (!time_to_abort)
     return false;
@@ skipping 479 matching lines @@
 }
 
 void FromGWSPageLoadMetricsLogger::OnUserInput(
     const blink::WebInputEvent& event) {
   if (first_paint_triggered_ && !first_user_interaction_after_paint_) {
     DCHECK(!navigation_start_.is_null());
     first_user_interaction_after_paint_ =
         base::TimeTicks::Now() - navigation_start_;
   }
 }